-
-
Notifications
You must be signed in to change notification settings - Fork 371
fix: Correct redact UIView with higher zPosition #4309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/redact-under-translucent #4309 +/- ##
==================================================================
+ Coverage 91.676% 91.679% +0.003%
==================================================================
Files 617 617
Lines 50244 50252 +8
Branches 18100 18086 -14
==================================================================
+ Hits 46062 46071 +9
Misses 4089 4089
+ Partials 93 92 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
|
@brustolin CI failed |
|
I reran it for the 3rd time and it passed :/ |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Correct redact UIView with higher zPosition ([#4309](https://github.com/getsentry/sentry-cocoa/pull/4309))If none of the above apply, you can opt out of this check by adding |
📜 Description
Taking zPosition in account when redacting the SR
💚 How did you test it?
Unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps