Skip to content

Conversation

@brustolin
Copy link
Contributor

📜 Description

Taking zPosition in account when redacting the SR

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.679%. Comparing base (ffdf298) to head (87f9520).

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##           fix/redact-under-translucent     #4309       +/-   ##
==================================================================
+ Coverage                        91.676%   91.679%   +0.003%     
==================================================================
  Files                               617       617               
  Lines                             50244     50252        +8     
  Branches                          18100     18086       -14     
==================================================================
+ Hits                              46062     46071        +9     
  Misses                             4089      4089               
+ Partials                             93        92        -1     
Files with missing lines Coverage Δ
Sources/Swift/Tools/UIRedactBuilder.swift 100.000% <100.000%> (ø)
...ests/SentryTests/SentryViewPhotographerTests.swift 99.082% <100.000%> (+0.082%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdf298...87f9520. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.56 ms 1263.69 ms 20.12 ms
Size 21.58 KiB 710.79 KiB 689.21 KiB

Baseline results on branch: fix/redact-under-translucent

Startup times

Revision Plain With Sentry Diff
1e7fd29 1242.35 ms 1260.59 ms 18.24 ms

App size

Revision Plain With Sentry Diff
1e7fd29 21.58 KiB 707.14 KiB 685.56 KiB

@bruno-garcia
Copy link
Member

@brustolin CI failed

@armcknight
Copy link
Member

I reran it for the 3rd time and it passed :/

@brustolin brustolin merged commit 7878f04 into fix/redact-under-translucent Sep 13, 2024
@brustolin brustolin deleted the fix/redact-zposition branch September 13, 2024 14:03
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Correct redact UIView with higher zPosition ([#4309](https://github.com/getsentry/sentry-cocoa/pull/4309))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 64414ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants