Skip to content

Conversation

@armcknight
Copy link
Member

Some logging I've added while debugging various things, figured I'd put them up to share, and so I don't have to rewrite them yet again in the future (some of these I've done multiple times now)

#skip-changelog

@armcknight armcknight changed the title chore: add debug logging to transport layer chore: debug logging Aug 8, 2024
@codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.524%. Comparing base (649d940) to head (ef95547).
Report is 29 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4266       +/-   ##
=============================================
+ Coverage   91.424%   91.524%   +0.100%     
=============================================
  Files          611       612        +1     
  Lines        49163     49498      +335     
  Branches     17757     17912      +155     
=============================================
+ Hits         44947     45303      +356     
+ Misses        4123      4102       -21     
  Partials        93        93               
Files Coverage Δ
...entry/Profiling/SentryProfiledTracerConcurrency.mm 98.734% <100.000%> (+0.049%) ⬆️
Sources/Sentry/Profiling/SentryProfilerState.mm 99.328% <100.000%> (+0.048%) ⬆️
Sources/Sentry/SentryFramesTracker.m 98.701% <100.000%> (+0.008%) ⬆️
Sources/Sentry/SentryHttpTransport.m 98.850% <100.000%> (+0.013%) ⬆️
Sources/Sentry/SentryNSURLRequest.m 81.034% <100.000%> (+0.332%) ⬆️
Sources/Sentry/SentryScreenFrames.m 75.757% <100.000%> (+9.090%) ⬆️

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649d940...ef95547. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.92 ms 1245.49 ms 16.57 ms
Size 21.58 KiB 700.27 KiB 678.69 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
78d5983 1229.98 ms 1245.60 ms 15.62 ms
50bb751 1230.94 ms 1238.69 ms 7.75 ms
0341c52 1235.76 ms 1246.67 ms 10.91 ms
d257eb9 1226.08 ms 1256.54 ms 30.46 ms
4259afd 1234.04 ms 1256.76 ms 22.72 ms
4ae9b7a 1239.76 ms 1255.48 ms 15.72 ms
3e7aa41 1214.02 ms 1238.84 ms 24.82 ms
efd8ddb 1208.88 ms 1234.12 ms 25.24 ms
154f795 1250.38 ms 1274.54 ms 24.16 ms
dfde86d 1215.12 ms 1221.30 ms 6.18 ms

App size

Revision Plain With Sentry Diff
78d5983 20.76 KiB 427.80 KiB 407.04 KiB
50bb751 21.58 KiB 417.86 KiB 396.27 KiB
0341c52 21.58 KiB 544.86 KiB 523.27 KiB
d257eb9 20.76 KiB 433.23 KiB 412.47 KiB
4259afd 20.76 KiB 419.70 KiB 398.94 KiB
4ae9b7a 21.58 KiB 632.04 KiB 610.46 KiB
3e7aa41 20.76 KiB 432.31 KiB 411.55 KiB
efd8ddb 21.58 KiB 678.19 KiB 656.61 KiB
154f795 20.76 KiB 435.25 KiB 414.49 KiB
dfde86d 21.58 KiB 414.57 KiB 392.99 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight armcknight merged commit d26c417 into main Aug 9, 2024
@armcknight armcknight deleted the armcknight/chore/debug-logging branch August 9, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants