Skip to content

test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brustolin merged 2 commits into from
Nov 15, 2022
Merged

test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject #2392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baff8ad
Update SentrySerializationTests.swift
brustolin Nov 15, 2022
edae8ff
Update SentrySerializationTests.swift
brustolin Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Tests/SentryTests/Helper/SentrySerializationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ class SentrySerializationTests: XCTestCase {
data = try SentrySerialization.data(withJSONObject: json)
} catch {
exp.fulfill()
XCTAssertEqual(error.localizedDescription, "Event cannot be converted to JSON (Invalid type in JSON write (__NSTaggedDate))")
//Depending of the iOS version, the underlying type of NSDate may change.
//Knowing that we have an error is enough.
XCTAssertTrue(error.localizedDescription.starts(with: "Event cannot be converted to JSON (Invalid type in JSON write"))
}
waitForExpectations(timeout: 1)
XCTAssertNil(data)
Expand Down