-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated crash reports: regular and WatchdogTermination #3207
Comments
The main issue is that you can no longer accurately tell the real app's crash rate. It seems there is already logic that should take care of the duplicates, but it doesn't seem to work every time. // The app crashed on the previous run. No Watchdog Termination.
if (self.crashAdapter.crashedLastLaunch) {
return NO;
} I checked one of the events from the screenshots I provided, and they contain identical breadcrumbs and timestamps. |
Hi @kean, thanks for the report! We'll investigate. Please note that due to current vacations and holidays we may be slower to response. |
Hello @kean. Is this a React Native project? |
Hey, @brustolin. Yes, parts of it are, and I think both of these crashes happened in the RN part. |
@krystofwoldrich do you have any idea what may cause this? Can you take a look? |
The WatchDog issue is created based on a heuristic, are you or some library call Is it the WordPress-iOS app that you linked the issue to? Are you able to reproduce it locally? |
@kean could you provide more information and ideally answer above questions? Does it still occur? |
The crashes I originally reported were all coming the React Native part of the app.
Yes, that's the correct repo, but I don't have a way to reproduce it. This issue is currently much less of a concern as we managed to bring the overall number of the |
@kean, what did you do to achieve this?
Disabling app hang monitoring only stops the SDK from reporting app hangs, but the app hang tracker still runs to avoid tracking app hangs that get killed as watchdog terminations. I would be surprised if that would be the main reason. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Platform
iOS
Installed
CocoaPods
Version
8.9.2
Steps to Reproduce
In some scenarios, but not all, a single crash gets reported twice:
Expected Result
A crash results in a single even on Sentry. The crash rate is accurate.
Actual Result
The reported crash rate is inaccurate.
Occasion #1
Occasion #2
Are you willing to submit a PR?
No response
The text was updated successfully, but these errors were encountered: