chore: Use YES and NO for objc BOOL (#2717)

hanging true to YES and false to NO in objc files.

Author: brustolin

Sources/Sentry/SentryANRTracker.m

@@ -72,7 +72,7 @@ - (void)detectANRs
     NSTimeInterval sleepInterval = self.timeoutInterval / reportThreshold;
 
     // Canceling the thread can take up to sleepInterval.
-    while (true) {
+    while (YES) {
         @synchronized(threadLock) {
             if (state != kSentryANRTrackerRunning) {
                 break;

Sources/Sentry/SentryBreadcrumbTracker.m

@@ -156,7 +156,7 @@ + (BOOL)avoidSender:(id)sender forTarget:(id)target action:(NSString *)action
                                                    forControlEvent:UIControlEventEditingChanged];
         return [actions containsObject:action];
     }
-    return false;
+    return NO;
 }
 #endif
 

Sources/Sentry/SentryCrashDefaultMachineContextWrapper.m

@@ -27,7 +27,7 @@ + (void)load
 
 - (void)fillContextForCurrentThread:(struct SentryCrashMachineContext *)context
 {
-    sentrycrashmc_getContextForThread(sentrycrashthread_self(), context, true);
+    sentrycrashmc_getContextForThread(sentrycrashthread_self(), context, YES);
 }
 
 - (int)getThreadCount:(struct SentryCrashMachineContext *)context

Sources/Sentry/SentryCrashReportSink.m

@@ -81,7 +81,7 @@ - (void)sendReports:(NSArray *)reports onCompletion:(SentryCrashReportFilterComp
         }
     }
     if (onCompletion) {
-        onCompletion(sentReports, TRUE, nil);
+        onCompletion(sentReports, YES, nil);
     }
 }
 

Sources/Sentry/SentryHub.m

@@ -97,7 +97,7 @@ - (void)startSession
         }
         _session = [[SentrySession alloc] initWithReleaseName:options.releaseName];
 
-        if (_errorsBeforeSession > 0 && options.enableAutoSessionTracking == true) {
+        if (_errorsBeforeSession > 0 && options.enableAutoSessionTracking == YES) {
             _session.errors = _errorsBeforeSession;
             _errorsBeforeSession = 0;
         }
@@ -356,7 +356,7 @@ - (SentryId *)captureEvent:(SentryEvent *)event
                         customSamplingContext:(NSDictionary<NSString *, id> *)customSamplingContext
 {
     return [self startTransactionWithContext:transactionContext
-                                 bindToScope:false
+                                 bindToScope:NO
                        customSamplingContext:customSamplingContext];
 }
 

Sources/Sentry/SentryPerformanceTracker.m

@@ -65,7 +65,7 @@ - (SentrySpanId *)startSpanWithName:(NSString *)name
                                                  operation:operation];
 
         [SentrySDK.currentHub.scope useSpan:^(id<SentrySpan> span) {
-            BOOL bindToScope = true;
+            BOOL bindToScope = YES;
             if (span != nil) {
                 if ([SentryUIEventTracker isUIEventOperation:span.operation]) {
                     SENTRY_LOG_DEBUG(
@@ -74,7 +74,7 @@ - (SentrySpanId *)startSpanWithName:(NSString *)name
                 } else {
                     SENTRY_LOG_DEBUG(@"Current scope span %@ is not tracking a UI event",
                         span.spanId.sentrySpanIdString);
-                    bindToScope = false;
+                    bindToScope = NO;
                 }
             }
 

Sources/Sentry/SentrySpanContext.m

@@ -9,7 +9,7 @@ @implementation SentrySpanContext
 
 - (instancetype)initWithOperation:(NSString *)operation
 {
-    return [self initWithOperation:operation sampled:false];
+    return [self initWithOperation:operation sampled:NO];
 }
 
 - (instancetype)initWithOperation:(NSString *)operation sampled:(SentrySampleDecision)sampled

Sources/Sentry/SentryStacktraceBuilder.m

@@ -86,7 +86,7 @@ - (SentryStacktrace *)buildStackTraceFromStackEntries:(SentryCrashStackEntry *)e
 - (SentryStacktrace *)buildStacktraceForThread:(SentryCrashThread)thread
                                        context:(struct SentryCrashMachineContext *)context
 {
-    sentrycrashmc_getContextForThread(thread, context, false);
+    sentrycrashmc_getContextForThread(thread, context, NO);
     SentryCrashStackCursor stackCursor;
     sentrycrashsc_initWithMachineContext(&stackCursor, MAX_STACKTRACE_LENGTH, context);
 

Sources/Sentry/SentrySubClassFinder.m

@@ -77,7 +77,7 @@ - (void)actOnSubclassesOfViewControllerInImage:(NSString *)imageName block:(void
 - (BOOL)isClass:(Class)childClass subClassOf:(Class)parentClass
 {
     if (!childClass || childClass == parentClass) {
-        return false;
+        return NO;
     }
 
     // Using a do while loop, like pointed out in Cocoa with Love

Sources/Sentry/SentrySwizzle.m

@@ -27,7 +27,7 @@ - (SentrySwizzleOriginalIMP)getOriginalImplementation
 
 #if TEST
     @synchronized(self) {
-        self.originalCalled = true;
+        self.originalCalled = YES;
     }
 #endif