revert rename of sentryuser (#2462)

Reverted renaming of User to SentryUser

Author: brustolin

CHANGELOG.md

@@ -27,7 +27,6 @@ This version adds a dependency on Swift.
     - Rename `SentryScope.add(_ crumb:)` to `SentryScope.addBreadcrumb(_ crumb:)` (#2416)
     - Rename `SentryScope.add(_ attachment:)` to `SentryScope.addAttachment(_ attachment:)` (#2416)
     - Rename `Client` to `SentryClient` (#2403)
-    - Rename `User` to `SentryUser` (#2403)
 - Remove public APIs
     - Remove `SentryScope.apply(to:)` (#2416)
     - Remove `SentryScope.apply(to:maxBreadcrumb:)` (#2416)

Samples/iOS-Swift/iOS-Swift/ViewController.swift

@@ -20,7 +20,7 @@ class ViewController: UIViewController {
             scope.setTag(value: "swift", key: "language")
             scope.setExtra(value: String(describing: self), key: "currentViewController")
 
-            let user = SentryUser(userId: "1")
+            let user = User(userId: "1")
             user.email = "[email protected]"
             scope.setUser(user)
 
@@ -33,7 +33,7 @@ class ViewController: UIViewController {
         }
 
         // Also works
-        let user = SentryUser(userId: "1")
+        let user = User(userId: "1")
         user.email = "[email protected]"
         SentrySDK.setUser(user)
 

Sources/Sentry/Public/SentryUser.h

@@ -3,6 +3,7 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
+NS_SWIFT_NAME(User)
 @interface SentryUser : NSObject <SentrySerializable, NSCopying>
 
 /**

Tests/SentryTests/Protocol/SentryUserTests.swift

@@ -3,7 +3,7 @@ import XCTest
 class SentryUserTests: XCTestCase {
 
     func testSerializationWithAllProperties() {
-        let user = TestData.user.copy() as! SentryUser
+        let user = TestData.user.copy() as! User
         let actual = user.serialize()
 
         // Changing the original doesn't modify the serialized
@@ -23,15 +23,15 @@ class SentryUserTests: XCTestCase {
     }
 
     func testSerializationWithOnlyId() {
-        let user = SentryUser(userId: "someid")
+        let user = User(userId: "someid")
         let actual = user.serialize()
 
         XCTAssertEqual(user.userId, actual["id"] as? String)
         XCTAssertEqual(1, actual.count)
     }
 
     func testSerializationWithoutId() {
-        let user = SentryUser()
+        let user = User()
         let actual = user.serialize()
 
         XCTAssertNil(actual["id"] as? String)
@@ -55,7 +55,7 @@ class SentryUserTests: XCTestCase {
     }
 
     func testIsEqualToCopy() {
-        XCTAssertEqual(TestData.user, TestData.user.copy() as! SentryUser)
+        XCTAssertEqual(TestData.user, TestData.user.copy() as! User)
     }
 
     func testNotIsEqual() {
@@ -67,15 +67,15 @@ class SentryUserTests: XCTestCase {
         testIsNotEqual { user in user.data?.removeAll() }
     }
 
-    func testIsNotEqual(block: (SentryUser) -> Void ) {
-        let user = TestData.user.copy() as! SentryUser
+    func testIsNotEqual(block: (User) -> Void ) {
+        let user = TestData.user.copy() as! User
         block(user)
         XCTAssertNotEqual(TestData.user, user)
     }
 
     func testCopyWithZone_CopiesDeepCopy() {
         let user = TestData.user
-        let copiedUser = user.copy() as! SentryUser
+        let copiedUser = user.copy() as! User
 
         // Modifying the original does not change the copy
         user.userId = ""
@@ -95,7 +95,7 @@ class SentryUserTests: XCTestCase {
         let queue = DispatchQueue(label: "SentryScopeTests", qos: .userInteractive, attributes: [.concurrent, .initiallyInactive])
         let group = DispatchGroup()
 
-        let user = TestData.user.copy() as! SentryUser
+        let user = TestData.user.copy() as! User
 
         for i in 0...20 {
             group.enter()

Tests/SentryTests/Protocol/TestData.swift

@@ -55,8 +55,8 @@ class TestData {
         return event
     }
 
-    static var user: SentryUser {
-        let user = SentryUser(userId: "id")
+    static var user: User {
+        let user = User(userId: "id")
         user.email = "[email protected]"
         user.username = "user123"
         user.ipAddress = "127.0.0.1"

Tests/SentryTests/SentryClientTests.swift

@@ -21,7 +21,7 @@ class SentryClientTest: XCTestCase {
         let messageAsString = "message"
         let message: SentryMessage
 
-        let user: SentryUser
+        let user: User
         let fileManager: SentryFileManager
         let random = TestRandom(value: 1.0)
 
@@ -44,7 +44,7 @@ class SentryClientTest: XCTestCase {
             event = Event()
             event.message = message
 
-            user = SentryUser()
+            user = User()
             user.email = "[email protected]"
             user.ipAddress = "127.0.0.1"
 

Tests/SentryTests/SentryHubTests.swift

@@ -180,7 +180,7 @@ class SentryHubTests: XCTestCase {
         let client = SentryClient(options: fixture.options)
         let hub = SentryHub(client: client, andScope: Scope())
 
-        let user = SentryUser()
+        let user = User()
         user.userId = "123"
         hub.setUser(user)
 

Tests/SentryTests/SentryScopeSwiftTests.swift

@@ -3,7 +3,7 @@ import XCTest
 class SentryScopeSwiftTests: XCTestCase {
 
     private class Fixture {
-        let user: SentryUser
+        let user: User
         let breadcrumb: Breadcrumb
         let scope: Scope
         let date: Date
@@ -25,7 +25,7 @@ class SentryScopeSwiftTests: XCTestCase {
         init() {
             date = Date(timeIntervalSince1970: 10)
 
-            user = SentryUser(userId: "id")
+            user = User(userId: "id")
             user.email = "[email protected]"
             user.username = "user123"
             user.ipAddress = ipAddress
@@ -85,7 +85,7 @@ class SentryScopeSwiftTests: XCTestCase {
         scope.setTag(value: "another", key: "another")
         scope.setExtra(value: "another", key: "another")
         scope.setContext(value: ["": 1], key: "another")
-        scope.setUser(SentryUser())
+        scope.setUser(User())
         scope.setDist("")
         scope.setEnvironment("")
         scope.setFingerprint([])
@@ -558,8 +558,8 @@ class SentryScopeSwiftTests: XCTestCase {
             clearInvocations += 1
         }
 
-        var user: SentryUser?
-        func setUser(_ user: SentryUser?) {
+        var user: User?
+        func setUser(_ user: User?) {
             self.user = user
         }
     }

Tests/SentryTests/SentrySessionTests.swift

@@ -38,7 +38,7 @@ class SentrySessionTestsSwift: XCTestCase {
     }
 
     func testCopySession() {
-        let user = SentryUser()
+        let user = User()
         user.email = "[email protected]"
 
         let session = SentrySession(releaseName: "1.0.0")

Tests/SentryTests/Transaction/SentryTraceStateTests.swift

@@ -28,7 +28,7 @@ class SentryTraceContextTests: XCTestCase {
             tracer = SentryTracer(transactionContext: TransactionContext(name: transactionName, operation: transactionOperation), hub: nil)
 
             scope = Scope()
-            scope.setUser(SentryUser(userId: userId))
+            scope.setUser(User(userId: userId))
             scope.userObject?.segment = userSegment
             scope.span = tracer