more feedback

philipphofmann · philipphofmann · commit 3bbf0fe5f3ce · 2025-05-28T10:32:32.000+02:00
diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp
@@ -78,9 +78,11 @@ captureStackTrace(void *, std::type_info *tinfo, void (*)(void *)) KEEP_FUNCTION
 {
     SENTRY_ASYNC_SAFE_LOG_TRACE("Entering captureStackTrace");
 
+    // We handle NSExceptions in SentryCrashMonitor_NSException.
     if (tinfo != nullptr && strcmp(tinfo->name(), "NSException") == 0) {
         return;
     }
+
     if (g_captureNextStackTrace) {
         sentrycrashsc_initSelfThread(&g_stackCursor, 2);
     }
@@ -101,6 +103,8 @@ __cxa_throw(
     SENTRY_ASYNC_SAFE_LOG_TRACE("Entering __cxa_throw");
 
     static cxa_throw_type orig_cxa_throw = NULL;
+
+    // Fallback if swap_cxa_throw is disabled.
     if (sentrycrashct_is_cxa_throw_swapped() == false) {
         captureStackTrace(thrown_exception, tinfo, dest);
     }

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,11 @@ captureStackTrace(void , std::type_info tinfo, void ()(void )) KEEP_FUNCTION`
`78`	`78`	`{`
`79`	`79`	`SENTRY_ASYNC_SAFE_LOG_TRACE("Entering captureStackTrace");`
`80`	`80`
	`81`	`+ // We handle NSExceptions in SentryCrashMonitor_NSException.`
`81`	`82`	`if (tinfo != nullptr && strcmp(tinfo->name(), "NSException") == 0) {`
`82`	`83`	`return;`
`83`	`84`	`}`
	`85`	`+`
`84`	`86`	`if (g_captureNextStackTrace) {`
`85`	`87`	`sentrycrashsc_initSelfThread(&g_stackCursor, 2);`
`86`	`88`	`}`
`@@ -101,6 +103,8 @@ __cxa_throw(`
`101`	`103`	`SENTRY_ASYNC_SAFE_LOG_TRACE("Entering __cxa_throw");`
`102`	`104`
`103`	`105`	`static cxa_throw_type orig_cxa_throw = NULL;`
	`106`	`+`
	`107`	`+ // Fallback if swap_cxa_throw is disabled.`
`104`	`108`	`if (sentrycrashct_is_cxa_throw_swapped() == false) {`
`105`	`109`	`captureStackTrace(thrown_exception, tinfo, dest);`
`106`	`110`	`}`