Skip to content

Commit 21fd61f

Browse files
test: Speed up testDefaultMaxEnvelopesConcurrent (#2967)
Set maxCacheItems to 1, so the testDefaultMaxEnvelopesConcurrent test doesn't need to store 30 envelope items but only 1 for the max envelopes items logic to run.
1 parent 65c78f3 commit 21fd61f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Tests/SentryTests/Helper/SentryFileManagerTests.swift

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,15 +244,18 @@ class SentryFileManagerTests: XCTestCase {
244244
}
245245

246246
func testDefaultMaxEnvelopesConcurrent() {
247+
let maxCacheItems = 1
248+
let sut = fixture.getSut(maxCacheItems: UInt(maxCacheItems))
249+
247250
let parallelTaskAmount = 5
248251
let queue = DispatchQueue(label: "testDefaultMaxEnvelopesConcurrent", qos: .userInitiated, attributes: [.concurrent, .initiallyInactive])
249252

250253
let envelopeStoredExpectation = expectation(description: "Envelope stored")
251254
envelopeStoredExpectation.expectedFulfillmentCount = parallelTaskAmount
252255
for _ in 0..<parallelTaskAmount {
253256
queue.async {
254-
for _ in 0...(self.fixture.maxCacheItems + 5) {
255-
self.sut.store(TestConstants.envelope)
257+
for _ in 0...(maxCacheItems + 5) {
258+
sut.store(TestConstants.envelope)
256259
}
257260
envelopeStoredExpectation.fulfill()
258261
}
@@ -262,7 +265,7 @@ class SentryFileManagerTests: XCTestCase {
262265
wait(for: [envelopeStoredExpectation], timeout: 10)
263266

264267
let events = sut.getAllEnvelopes()
265-
XCTAssertEqual(fixture.maxCacheItems, events.count)
268+
XCTAssertEqual(maxCacheItems, events.count)
266269
}
267270

268271
func testMaxEnvelopesSet() {

0 commit comments

Comments
 (0)