Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new-type for OrganizationId #4069

Closed
Dav1dde opened this issue Sep 24, 2024 · 0 comments · Fixed by #4159
Closed

Introduce new-type for OrganizationId #4069

Dav1dde opened this issue Sep 24, 2024 · 0 comments · Fixed by #4159
Assignees
@Litarnus
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. onboarding

Comments

@Dav1dde
Copy link
Member

Dav1dde commented Sep 24, 2024

We already have a new-types for a few things, like the ProjectId, we should also have one for the organization id. Some crates already define type aliases type OrganizationId = u64, all of these should be replaced with a proper new-type.
@Dav1dde Dav1dde added filler Requires little effort to resolve. Ready to be picked up anytime. onboarding labels Sep 24, 2024
@Litarnus Litarnus self-assigned this Oct 21, 2024
@Litarnus Litarnus linked a pull request Oct 24, 2024 that will close this issue
ref: Replace organization id type with newtype #4159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Litarnus Litarnus

Labels
filler Requires little effort to resolve. Ready to be picked up anytime. onboarding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: Replace organization id type with newtype getsentry/relay
2 participants
@Dav1dde @Litarnus