Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbound Filter Outcome Reason #2850

Closed
smeubank opened this issue Dec 13, 2023 · 10 comments · Fixed by getsentry/sentry#73840
Closed

Inbound Filter Outcome Reason #2850

smeubank opened this issue Dec 13, 2023 · 10 comments · Fixed by getsentry/sentry#73840
Assignees
Labels
filler Requires little effort to resolve. Ready to be picked up anytime.

Comments

@smeubank
Copy link
Member

smeubank commented Dec 13, 2023

Description
We want to be able to categorize why errors dropped by a serverside inound filter are dropped. In this specific case we are trying to analyze the full impact of filtering out hydration errors, but it maybe usefuly to do this in a more scalable way

image

link

If the filter is based on hyrdation error. Is this included in the "error message" reason? If yes could that be added to the outcome reason? error "message: hydration"

the in product toggle found in project inbound filter settings

image
@jjbayer
Copy link
Member

jjbayer commented Dec 14, 2023

Will be fixed by getsentry/sentry#57799.

@bruno-garcia
Copy link
Member

This will really help when debugging customer who reach out about data not being in. "My replay is sampled but the error was dropped" and we dunno what filter was applied

@mydea
Copy link
Member

mydea commented Jan 19, 2024

Referencing getsentry/sentry-javascript#10036, as that may be related to this!

@smeubank
Copy link
Member Author

@billyvg also stumbled across this, related to customers calling in and not having enough insight

@jjbayer
Copy link
Member

jjbayer commented Jun 4, 2024

Should be straight-forward to port hydration errors to generic filters now, which would give them a separate outcome reason. We just need to extend the Getter on Event to access exception.values.value. @iker-barriocanal maybe something for you?

@iker-barriocanal
Copy link
Contributor

@smeubank do you have a list of filters we could target? I see special cases for hydration errors and chunk load errors. Getting reasons for these two specifically is quite straightforward.

@smeubank
Copy link
Member Author

smeubank commented Jun 5, 2024

for a list for filters, we should be able to manage at least what is here and toggleable

  • browser extensions
  • health check (transations)
  • legacy browsers
  • localhost
  • web crawlers
  • hydration errors
  • chunkLoadError(s)

image

@iker-barriocanal
Copy link
Contributor

After discussing on Slack, the only missing filters without a reason in the above list are the hydration and chunk load errors.

@olksdr olksdr added the filler Requires little effort to resolve. Ready to be picked up anytime. label Jun 10, 2024
@iker-barriocanal iker-barriocanal self-assigned this Jun 24, 2024
@iambriccardo
Copy link
Member

We are now working on the foundational elements needed to allow the expression of error message rules generically. This is the PR for reference: #3791.

The next steps are:

  1. Implementing the new looping semantics
  2. Implementing the rule generation in Sentry

@iambriccardo
Copy link
Member

iambriccardo commented Jul 8, 2024

Will use this query to validate the new outcomes:

MATCH (outcomes)
SELECT reason, count(reason) BY reason
WHERE project_id = 11276 AND org_id = 1
AND outcome = 1
AND timestamp >= toDateTime('2024-07-01T10:30:30')
AND timestamp < toDateTime('2024-07-30T10:30:30')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filler Requires little effort to resolve. Ready to be picked up anytime.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants