Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger is failing with 403s #47

Closed
sl0thentr0py opened this issue Nov 11, 2022 · 4 comments
Closed

Danger is failing with 403s #47

sl0thentr0py opened this issue Nov 11, 2022 · 4 comments

Comments

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Nov 11, 2022

Environment

https://github.com/getsentry/sentry-ruby/blob/7ec474805aea75c52e2af1a7882d10cfe8ddc028/.github/workflows/danger.yml#L9

Steps to Reproduce

we started using danger in sentry-ruby recently to enforce changelogs

Expected Result

danger works

Actual Result

fails with 403
https://github.com/getsentry/sentry-ruby/actions/runs/3445263716/jobs/5748774925#step:4:59

@vaind
Copy link
Collaborator

vaind commented Nov 11, 2022

Danger failed in your PR because it found an issue: getsentry/sentry-ruby#1876 (comment)

The one printed in the action log output is unrelated and doesn't make the action fail. I know it's confusing, it did confuse me too in the past, but AFAIK there isn't much to do about it... I'll think about what can be done to improve this, e.g. hide the issue from logs, or show actual errors also in logs (If danger can do that, not sure...). For reference, here's danger-js issue related to the error printed in logs: danger/danger-js#1031

@sl0thentr0py
Copy link
Member Author

alright, thx @vaind, closing then

@sl0thentr0py
Copy link
Member Author

@vaind how do I tell danger to ignore this issue, don't particularly care about this right now and all our other actions just use tags on github actions

@vaind
Copy link
Collaborator

vaind commented Nov 11, 2022

@vaind how do I tell danger to ignore this issue, don't particularly care about this right now and all our other actions just use tags on github actions

There's no way to disable specific rules at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants