Skip to content

Commit a420933

Browse files
committed
Fix tests
1 parent dc6b2a9 commit a420933

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

client/app/components/QuerySelector.jsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,10 @@ export default function QuerySelector(props) {
6767
dataSource={searchResults}
6868
rowKey="id"
6969
renderItem={query => (
70-
<List.Item className={cx("query-selector-result", "ant-list-item-link", { inactive: query.is_draft })}>
71-
<a onClick={query.is_draft ? null : () => selectQuery(query.id)} data-test={`QueryId${query.id}`}>
70+
<List.Item className={cx("ant-list-item-link", { inactive: query.is_draft })}>
71+
<a
72+
onClick={query.is_draft ? null : () => selectQuery(query.id)}
73+
data-test={`QuerySelector.Query${query.id}`}>
7274
{query.name}
7375
<QueryTagsControl isDraft={query.is_draft} tags={query.tags} className="inline-tags-control m-l-10" />
7476
</a>
@@ -108,8 +110,7 @@ export default function QuerySelector(props) {
108110
value={q.id}
109111
key={q.id}
110112
disabled={disabled}
111-
className="query-selector-result"
112-
data-test={`QueryId${q.id}`}>
113+
data-test={`QuerySelector.Query${q.id}`}>
113114
{q.name}{" "}
114115
<QueryTagsControl
115116
isDraft={q.is_draft}

client/app/components/dashboards/dashboard-widget/Widget.less

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,12 @@
234234

235235
.refresh-button,
236236
.btn__refresh {
237+
display: inline-block;
238+
vertical-align: middle;
237239
cursor: pointer;
238240
padding: 5px 10px;
241+
font-size: 12px;
242+
line-height: 1.5;
239243

240244
&:first-child {
241245
margin-left: -10px;

client/cypress/integration/alert/create_alert_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe("Create Alert", () => {
1717
cy.getByTestId("QuerySelector")
1818
.click()
1919
.type("Create Alert Query");
20-
cy.get(`.query-selector-result[data-test="QueryId${queryId}"]`).click();
20+
cy.getByTestId(`QuerySelector.Query${queryId}`).click();
2121
cy.getByTestId("Criteria").should("exist");
2222
cy.percySnapshot("Create Alert second screen");
2323
});

client/cypress/integration/dashboard/sharing_spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe("Dashboard Sharing", () => {
2828
editDashboard();
2929
cy.getByTestId("AddWidgetButton").click();
3030
cy.getByTestId("AddWidgetDialog").within(() => {
31-
cy.get(`.query-selector-result[data-test="QueryId${queryId}"]`).click();
31+
cy.getByTestId(`QuerySelector.Query${queryId}`).click();
3232
});
3333
cy.contains("button", "Add to Dashboard").click();
3434
cy.getByTestId("AddWidgetDialog").should("not.exist");
@@ -153,7 +153,7 @@ describe("Dashboard Sharing", () => {
153153
editDashboard();
154154
cy.getByTestId("AddWidgetButton").click();
155155
cy.getByTestId("AddWidgetDialog").within(() => {
156-
cy.get(`.query-selector-result[data-test="QueryId${queryId}"]`).click();
156+
cy.getByTestId(`QuerySelector.Query${queryId}`).click();
157157
});
158158
cy.contains("button", "Add to Dashboard").click();
159159
cy.getByTestId("AddWidgetDialog").should("not.exist");

client/cypress/integration/dashboard/widget_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ describe("Widget", () => {
2424
editDashboard();
2525
cy.getByTestId("AddWidgetButton").click();
2626
cy.getByTestId("AddWidgetDialog").within(() => {
27-
cy.get(`.query-selector-result[data-test="QueryId${queryId}"]`).click();
27+
cy.getByTestId(`QuerySelector.Query${queryId}`).click();
2828
});
2929
cy.contains("button", "Add to Dashboard").click();
3030
cy.getByTestId("AddWidgetDialog").should("not.exist");

0 commit comments

Comments
 (0)