Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 deprecation task list #2122

Closed
9 tasks done
Kwpolska opened this issue Sep 26, 2015 · 10 comments
Closed
9 tasks done

Python 2.7 deprecation task list #2122

Kwpolska opened this issue Sep 26, 2015 · 10 comments

Comments

@Kwpolska
Copy link
Member

Kwpolska commented Sep 26, 2015

  • Have @ralsina switch his virtualenv to Python 3.4 or better
  • Add deprecation warning to v7.7.2 (Add 2.7 deprecation warning #2121)
  • Switch flake8/pep257 checking to Python 3.5
  • Switch invariance testing to Python 3.5
  • Switch all remaining infrastructure (plugins site auto-build→(server is now Ubuntu 16.04, not blocked)
  • Figure out how to get -py3-only wheels: drop universal setting from setup.cfg
  • Clean up AUR packages (python-nikola → nikola; python2-nikola → /dev/null)
  • Unpin doit version
  • Write post-mortem (in 2017 maybe)
@Kwpolska
Copy link
Member Author

Tried invariance. For now, charts and RSS are untestable, because they are using dicts. We can probably just delete charts from invariance. But RSS feeds are a bigger problem, because we can’t fix that. Maybe we could migrate to feedgenerator instead of using PyRSS2Gen, which is ancient?

@ralsina
Copy link
Member

ralsina commented Sep 27, 2015

@Kwpolska I don't understand the comment about charts and RSS?

@Kwpolska
Copy link
Member Author

@ralsina It’s our friend, invariance testing. Charts and RSS feeds (pygal and pyrss2gen, that is) implement some things as dicts. Which have random order when printing on Python 3. And you can guess how well this works with diff.

@ralsina
Copy link
Member

ralsina commented Sep 28, 2015

I am +1 for switching to feedgenerator or whatever. pygal I guess we could disable when in invariance mode? Just monkeypatch the directive into repeating the source text or something like it.

@Kwpolska
Copy link
Member Author

I added charts.txt it to the excluded files list, so pygal’s not a problem.

So, we have to figure out how to work with feedgenerator and use it.

@msnoigrs
Copy link
Contributor

I have already ported to feedgenerator in my private repository. FYI

@Kwpolska
Copy link
Member Author

We’d love a pull request then.

@msnoigrs
Copy link
Contributor

There are two caution points for using my feedgenerator-based code so far.

  1. It use my custom feedgenerator that contains some bugfixes and some enhancements. https://github.com/masayuko/python-feedgen
  2. The code is designed to prevent as little conflict as possible in order to make it easier to merge into the original nikola. So it need a few adjustments for PR.

@ralsina ralsina modified the milestones: v8.0.0, 7.8.1 Aug 29, 2016
@Kwpolska Kwpolska modified the milestones: v7.8.1, v7.8.2 Oct 13, 2016
@Kwpolska Kwpolska modified the milestones: v7.8.2, v7.8.3 Jan 8, 2017
@Kwpolska Kwpolska modified the milestones: v7.8.4, v7.8.5 Mar 26, 2017
@Kwpolska Kwpolska modified the milestones: v7.8.5, v7.8.6 May 14, 2017
@Kwpolska Kwpolska modified the milestones: v7.8.6, v7.8.5 May 14, 2017
@Kwpolska Kwpolska modified the milestones: v7.8.6, v7.8.7 May 26, 2017
@Kwpolska Kwpolska modified the milestones: v7.8.7, v7.8.8 Jun 4, 2017
@Kwpolska Kwpolska modified the milestones: v7.8.8, v7.8.9, v8.0.0 Jun 12, 2017
@Kwpolska Kwpolska self-assigned this Jun 16, 2017
@ralsina
Copy link
Member

ralsina commented Mar 9, 2018

All in all, this seems done. Agree @Kwpolska? If yes, let's close it.

@Kwpolska
Copy link
Member Author

Kwpolska commented Mar 9, 2018

Yes, it is all done. Closing.

@Kwpolska Kwpolska closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants