Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets provided by plugins are ignored by nikola auto #2044

Closed
ralsina opened this issue Sep 9, 2015 · 2 comments
Closed

Assets provided by plugins are ignored by nikola auto #2044

ralsina opened this issue Sep 9, 2015 · 2 comments
Labels
Milestone

Comments

@ralsina
Copy link
Member

ralsina commented Sep 9, 2015

For example, localsearch has CSS and JS that is inside the plugin, and are copied by a task. If you edit those, auto rebuild is not triggered.

Possible solutions:

  1. Just watch the plugins folder. Also triggers rebuild if the plugin changes but who cares?
  2. Have plugins optionally register paths for watching but this gets complicated very fast

I'd say 1?

@ralsina ralsina added the bug label Sep 9, 2015
@ralsina ralsina added this to the 7.7.1 milestone Sep 9, 2015
@Kwpolska
Copy link
Member

Kwpolska commented Sep 9, 2015

Just watch the plugins folder. Also triggers rebuild if the plugin changes but who cares?

Don’t/didn’t we rebuild on Nikola code changes before? Most people would actually consider this a nice touch.

@ralsina
Copy link
Member Author

ralsina commented Sep 9, 2015

@Kwpolska We used to, when livereload. Wonder if it still happens... no, doesn't happen anymore. I'll make it watch plugins and ~/.nikola/plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants