Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOT RoleAlias support - API and CloudFormation object, enhancements to search_index() response #8292

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jsuchenia
Copy link
Contributor

@jsuchenia jsuchenia commented Nov 4, 2024

In this PR I'd like to contribute:

  • IoT RoleAlias API: create_role_alias(), list_role_aliases(), describe_role_alias(), update_role_alias(), delete_role_alias()
  • AWS::IoT::RoleAlias CloudFormation object

Enhance search() index response - add missing thingGroupNames and shadow fields

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 99.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.56%. Comparing base (bf49e22) to head (cd0d046).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
moto/iot/models.py 98.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8292   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files        1158     1158           
  Lines      100744   100843   +99     
=======================================
+ Hits        95267    95365   +98     
- Misses       5477     5478    +1     
Flag Coverage Δ
servertests 28.87% <28.00%> (-0.01%) ⬇️
unittests 94.54% <99.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsuchenia jsuchenia changed the title IOT RoleAlias support - API and CloudFormation object IOT RoleAlias support - API and CloudFormation object, enhancements to search_index() response Nov 5, 2024
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moto-payments-app
Copy link

Hi @jsuchenia,

Thank you so much for contributing to Moto!

To show our thanks, we'd like to share some of the donations that we've received with you. PR's like this are the big reason that Moto is as successful as it is - so it's only fair that you, as a contributor, get to share the spoils.

We've created a companion website with more information:
https://payments.getmoto.org/

Feel free to open a bug or discussion if you run into any problems:
https://github.com/getmoto/payments

@bblommers bblommers added this to the 5.0.21 milestone Nov 7, 2024
@bblommers bblommers merged commit 092bd10 into getmoto:master Nov 7, 2024
53 checks passed
@jsuchenia jsuchenia deleted the feat/iot-rolealias branch November 8, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants