feat: rm canvas logic, add in-browser loader

RohitR311 · RohitR311 · commit 1f99295c0f2c · 2025-11-03T16:00:46.000+05:30
diff --git a/src/components/browser/BrowserContent.tsx b/src/components/browser/BrowserContent.tsx
@@ -13,7 +13,7 @@ import {
 export const BrowserContent = () => {
   const { socket } = useSocketStore();
 
-  const [tabs, setTabs] = useState<string[]>(["current"]);
+  const [tabs, setTabs] = useState<string[]>(["Loading..."]);
   const [tabIndex, setTabIndex] = React.useState(0);
   const [showOutputData, setShowOutputData] = useState(false);
   const { browserWidth } = useBrowserDimensionsStore();
@@ -125,7 +125,7 @@ export const BrowserContent = () => {
   useEffect(() => {
     getCurrentTabs()
       .then((response) => {
-        if (response) {
+        if (response && response.length > 0) {
           setTabs(response);
         }
       })
diff --git a/src/components/browser/BrowserWindow.tsx b/src/components/browser/BrowserWindow.tsx
@@ -1,8 +1,6 @@
 import React, { useCallback, useContext, useEffect, useRef, useState } from 'react';
 import { useSocketStore } from '../../context/socket';
 import { Button } from '@mui/material';
-import Canvas from "../recorder/Canvas";
-import { Highlighter } from "../recorder/Highlighter";
 import { GenericModal } from '../ui/GenericModal';
 import { useActionContext } from '../../context/browserActions';
 import { useBrowserSteps, TextStep, ListStep } from '../../context/browserSteps';
@@ -38,12 +36,6 @@ interface AttributeOption {
     value: string;
 }
 
-interface ScreencastData {
-    image: string;
-    userId: string;
-    viewport?: ViewportInfo | null;
-}
-
 interface ViewportInfo {
     width: number;
     height: number;
@@ -146,8 +138,6 @@ const getAttributeOptions = (tagName: string, elementInfo: ElementInfo | null):
 export const BrowserWindow = () => {
     const { t } = useTranslation();
     const { browserWidth, browserHeight } = useBrowserDimensionsStore();
-    const [canvasRef, setCanvasReference] = useState<React.RefObject<HTMLCanvasElement> | undefined>(undefined);
-    const [screenShot, setScreenShot] = useState<string>("");
     const [highlighterData, setHighlighterData] = useState<{
         rect: DOMRect;
         selector: string;
@@ -1303,17 +1293,6 @@ export const BrowserWindow = () => {
     }, []); 
 
     const onMouseMove = (e: MouseEvent) => {
-        if (canvasRef && canvasRef.current && highlighterData) {
-            const canvasRect = canvasRef.current.getBoundingClientRect();
-            if (
-                e.pageX < canvasRect.left
-                || e.pageX > canvasRect.right
-                || e.pageY < canvasRect.top
-                || e.pageY > canvasRect.bottom
-            ) {
-                setHighlighterData(null);
-            }
-        }
     };
 
     const resetListState = useCallback(() => {
@@ -1331,46 +1310,22 @@ export const BrowserWindow = () => {
         }
     }, [getList, resetListState]);
 
-    const screencastHandler = useCallback((data: string | ScreencastData) => {
-        if (typeof data === 'string') {
-            setScreenShot(data);
-        } else if (data && typeof data === 'object' && 'image' in data) {
-            if (!data.userId || data.userId === user?.id) {
-                setScreenShot(data.image);
-                
-                if (data.viewport) {
-                    setViewportInfo(data.viewport);
-                }
-            }
-        }
-    }, [user?.id]);
-
     useEffect(() => {
         if (socket) {
-            socket.on("screencast", screencastHandler);
             socket.on("domcast", rrwebSnapshotHandler);
             socket.on("dom-mode-enabled", domModeHandler);
             socket.on("dom-mode-error", domModeErrorHandler);
         }
 
-        if (canvasRef?.current && !isDOMMode && screenShot) {
-            drawImage(screenShot, canvasRef.current);
-        }
-
         return () => {
             if (socket) {
-                socket.off("screencast", screencastHandler);
                 socket.off("domcast", rrwebSnapshotHandler);
                 socket.off("dom-mode-enabled", domModeHandler);
                 socket.off("dom-mode-error", domModeErrorHandler);
             }
         };
     }, [
         socket,
-        screenShot,
-        canvasRef,
-        isDOMMode,
-        screencastHandler,
         rrwebSnapshotHandler,
         domModeHandler,
         domModeErrorHandler,
@@ -1847,24 +1802,7 @@ export const BrowserWindow = () => {
 
     const handleClick = (e: React.MouseEvent<HTMLDivElement>) => {
       if (highlighterData) {
-        let shouldProcessClick = false;
-
-        if (!isDOMMode && canvasRef?.current) {
-          const canvasRect = canvasRef.current.getBoundingClientRect();
-          const clickX = e.clientX - canvasRect.left;
-          const clickY = e.clientY - canvasRect.top;
-          const highlightRect = highlighterData.rect;
-          const mappedRect =
-            coordinateMapper.mapBrowserRectToCanvas(highlightRect);
-
-          shouldProcessClick =
-            clickX >= mappedRect.left &&
-            clickX <= mappedRect.right &&
-            clickY >= mappedRect.top &&
-            clickY <= mappedRect.bottom;
-        } else {
-          shouldProcessClick = true;
-        }
+        const shouldProcessClick = true;
 
         if (shouldProcessClick) {
           const options = getAttributeOptions(
@@ -2209,17 +2147,7 @@ export const BrowserWindow = () => {
             !showAttributeModal &&
             highlighterData?.rect != null && (
               <>
-                {!isDOMMode && canvasRef?.current && (
-                  <Highlighter
-                    unmodifiedRect={highlighterData?.rect}
-                    displayedSelector={highlighterData?.selector}
-                    width={dimensions.width}
-                    height={dimensions.height}
-                    canvasRect={canvasRef.current.getBoundingClientRect()}
-                  />
-                )}
-
-                {isDOMMode && highlighterData && (
+                {highlighterData && (
                   <div
                   id="dom-highlight-overlay"
                   style={{
@@ -2355,31 +2283,27 @@ export const BrowserWindow = () => {
             borderRadius: "0px 0px 5px 5px",
           }}
         >
-          {isDOMMode ? (
+          {currentSnapshot ? (
             <>
-              {currentSnapshot ? (
-                <DOMBrowserRenderer
-                  width={dimensions.width}
-                  height={dimensions.height}
-                  snapshot={currentSnapshot}
-                  getList={getList}
-                  getText={getText}
-                  listSelector={listSelector}
-                  cachedChildSelectors={cachedChildSelectors}
-                  paginationMode={paginationMode}
-                  paginationType={paginationType}
-                  limitMode={limitMode}
-                  isCachingChildSelectors={isCachingChildSelectors}
-                  onHighlight={domHighlighterHandler}
-                  onElementSelect={handleDOMElementSelection}
-                  onShowDatePicker={handleShowDatePicker}
-                  onShowDropdown={handleShowDropdown}
-                  onShowTimePicker={handleShowTimePicker}
-                  onShowDateTimePicker={handleShowDateTimePicker}
-                />
-              ) : (
-                <DOMLoadingIndicator />
-              )}
+              <DOMBrowserRenderer
+                width={dimensions.width}
+                height={dimensions.height}
+                snapshot={currentSnapshot}
+                getList={getList}
+                getText={getText}
+                listSelector={listSelector}
+                cachedChildSelectors={cachedChildSelectors}
+                paginationMode={paginationMode}
+                paginationType={paginationType}
+                limitMode={limitMode}
+                isCachingChildSelectors={isCachingChildSelectors}
+                onHighlight={domHighlighterHandler}
+                onElementSelect={handleDOMElementSelection}
+                onShowDatePicker={handleShowDatePicker}
+                onShowDropdown={handleShowDropdown}
+                onShowTimePicker={handleShowTimePicker}
+                onShowDateTimePicker={handleShowDateTimePicker}
+              />
 
               {/* --- Loading overlay --- */}
               {isCachingChildSelectors && (
@@ -2492,11 +2416,7 @@ export const BrowserWindow = () => {
               )}
             </>
           ) : (
-            <Canvas
-              onCreateRef={setCanvasReference}
-              width={dimensions.width}
-              height={dimensions.height}
-            />
+            <DOMLoadingIndicator />
           )}
         </div>
       </div>
@@ -2591,26 +2511,6 @@ const DOMLoadingIndicator: React.FC = () => {
   );
 };
 
-
-const drawImage = (image: string, canvas: HTMLCanvasElement): void => {
-    const ctx = canvas.getContext('2d');
-    if (!ctx) return;
-
-    const img = new Image();
-    img.onload = () => {
-        requestAnimationFrame(() => {
-            ctx.drawImage(img, 0, 0, canvas.width, canvas.height);
-        });
-        if (image.startsWith('blob:')) {
-            URL.revokeObjectURL(image);
-        }
-    };
-    img.onerror = () => {
-        console.warn('Failed to load image');
-    };
-    img.src = image;
-};
-
 const modalStyle = {
     top: '50%',
     left: '50%',
diff --git a/src/pages/RecordingPage.tsx b/src/pages/RecordingPage.tsx
@@ -43,7 +43,7 @@ export const RecordingPage = ({ recordingName }: RecordingPageProps) => {
 
   const { setId, socket } = useSocketStore();
   const { setWidth } = useBrowserDimensionsStore();
-  const { browserId, setBrowserId, recordingId, recordingUrl, setRecordingUrl, setRecordingName, setRetrainRobotId } = useGlobalInfoStore();
+  const { browserId, setBrowserId, recordingId, recordingUrl, setRecordingUrl, setRecordingName, setRetrainRobotId, setIsDOMMode } = useGlobalInfoStore();
 
   const handleShowOutputData = useCallback(() => {
     setShowOutputData(true);
@@ -77,6 +77,8 @@ export const RecordingPage = ({ recordingName }: RecordingPageProps) => {
   useEffect(() => {
     let isCancelled = false;
     const handleRecording = async () => {
+      setIsDOMMode(true);
+
       const storedUrl = window.sessionStorage.getItem('recordingUrl');
       if (storedUrl && !recordingUrl) {
         setRecordingUrl(storedUrl);
@@ -137,9 +139,12 @@ export const RecordingPage = ({ recordingName }: RecordingPageProps) => {
       if (browserId === 'new-recording') {
         socket?.emit('new-recording');
       }
+      if (recordingUrl && socket) {
+        socket.emit('input:url', recordingUrl);
+      }
       setIsLoaded(true);
     }
-  }, [socket, browserId, recordingName, recordingId, isLoaded]);
+  }, [socket, browserId, recordingName, recordingId, recordingUrl, isLoaded]);
 
   useEffect(() => {
     socket?.on('loaded', handleLoaded);
@@ -153,26 +158,20 @@ export const RecordingPage = ({ recordingName }: RecordingPageProps) => {
     <ActionProvider>
       <BrowserStepsProvider>
         <div id="browser-recorder">
-          {isLoaded ? (
-            <>
-              <Grid container direction="row" style={{ flexGrow: 1, height: '100%' }}>
-                <Grid item xs={12} md={9} lg={9} style={{ height: '100%', overflow: 'hidden', position: 'relative' }}>
-                  <div style={{ height: '100%', overflow: 'auto' }}>
-                    <BrowserContent />
-                    <InterpretationLog isOpen={showOutputData} setIsOpen={setShowOutputData} />
-                  </div>
-                </Grid>
-                <Grid item xs={12} md={3} lg={3} style={{ height: '100%', overflow: 'hidden' }}>
-                  <div className="right-side-panel" style={{ height: '100%' }}>
-                    <RightSidePanel onFinishCapture={handleShowOutputData} />
-                    <BrowserRecordingSave />
-                  </div>
-                </Grid>
-              </Grid>
-            </>
-          ) : (
-            <Loader text={t('recording_page.loader.browser_startup', { url: recordingUrl })} />
-          )}
+          <Grid container direction="row" style={{ flexGrow: 1, height: '100%' }}>
+            <Grid item xs={12} md={9} lg={9} style={{ height: '100%', overflow: 'hidden', position: 'relative' }}>
+              <div style={{ height: '100%', overflow: 'auto' }}>
+                <BrowserContent />
+                <InterpretationLog isOpen={showOutputData} setIsOpen={setShowOutputData} />
+              </div>
+            </Grid>
+            <Grid item xs={12} md={3} lg={3} style={{ height: '100%', overflow: 'hidden' }}>
+              <div className="right-side-panel" style={{ height: '100%' }}>
+                <RightSidePanel onFinishCapture={handleShowOutputData} />
+                <BrowserRecordingSave />
+              </div>
+            </Grid>
+          </Grid>
         </div>
       </BrowserStepsProvider>
     </ActionProvider>
