Does not pass nilness analyzer

[uhthomas]

The package does not pass the nilness analyzer.

❯ go run golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness@latest ./...
-: impossible condition: non-nil == nil
/home/thomas/code/github.com/getkin/kin-openapi/openapi3/schema.go:1418:64: tautological condition: non-nil != nil
exit status 3

It would be nice to fix this :)

[fenollp]

Hi @uhthomas thanks for bringing this tool to our attention.
I'm having issues understanding the first error -: impossible condition: non-nil == nil could you help?
A cursory search did not prove fruitful: https://github.com/golang/go/search?q=nilness+-%3A+impossible+condition%3A+non-nil+%3D%3D+nil&type=issues
Maybe we can both work on making this report easier to act upon.

[uhthomas]

Hey @fenollp, that is strange. It looks like golang/go#31008 is the correct issue for this. Funnily enough, this repository is mentioned in a linked issue bazel-contrib/rules_go#2480.

The culprit is a nil check in visitJSON.

kin-openapi/openapi3/schema.go

Lines 798 to 799 in 590c85c

	case nil:
	return schema.visitJSONNull(settings)

The nilness analzyer passes when these two lines are removed.

I think #510 is a good idea, but it might be even better to use golangci-lint. What do you think?

Hope this helps! :)

[fenollp]

Thanks for finding the right issue and root causing this.

I'm down to add more linters and golangcilint is a good collection but false positives waste too much time.
I'd be happy to review a PR that adds a CI job with a minimal amount of linters (i.e. the ones that are surefire)