no matching operation was found when servers are defined

[crodwell]

using gin gonic is a framework, I can't seem to match a route to the the api spec

my code is pretty much as per example;

    router, _ := legacyrouter.NewRouter(s.ApiSpec)
    route, pathParams, err := router.FindRoute(c.Request)
    // no matching operation was found

I traced the problem to this part of the code

func (router *Router) FindRoute(req *http.Request) (*routers.Route, map[string]string, error) {
	method, url := req.Method, req.URL
	doc := router.doc
	// Get server
	servers := doc.Servers
	var server *openapi3.Server
	var remainingPath string
	var pathParams map[string]string
	if len(servers) == 0 {
		remainingPath = url.Path
	} else {
		var paramValues []string
		server, paramValues, remainingPath = servers.MatchURL(url)
		if server == nil {
				return nil, nil, &routers.RouteError{
				Reason: routers.ErrPathNotFound.Error(),
			}
		}

servers =

(openapi3.Servers) (len=1 cap=4) {
 (*openapi3.Server)(0xc000321b00)({
  ExtensionProps: (openapi3.ExtensionProps) {
   Extensions: (map[string]interface {}) {
   }
  },
  URL: (string) (len=24) "http://192.168.0.30:3000",
  Description: (string) (len=3) "API",
  Variables: (map[string]*openapi3.ServerVariable) <nil>
 })
}

url = /plans and that definitely exists in my openapi.yml file

[crodwell]

Interestingly when I duplicate that router and remove the offending code;

func (router *Router) FindRoute(req *http.Request) (*routers.Route, map[string]string, error) {
	method, url := req.Method, req.URL
	doc := router.doc
	// Get server
	// servers := doc.Servers
	// var server *openapi3.Server
	var remainingPath string
	var pathParams map[string]string
	// if len(servers) == 0 {
	remainingPath = url.Path
	/*} else {
		var paramValues []string
		server, paramValues, remainingPath = servers.MatchURL(url)
		if server == nil {
			return nil, nil, &routers.RouteError{
				Reason: routers.ErrPathNotFound.Error(),
			}
		}
		pathParams = make(map[string]string, 8)
		paramNames, _ := server.ParameterNames()
		for i, value := range paramValues {
			name := paramNames[i]
			pathParams[name] = value
		}
	}*/

	// Get PathItem
	root := router.node()
	var route *routers.Route

The validation works, no idea how or why

[fenollp]

Could you tell us more? e.g. what's the value of req.URL?

Ideally you'd formulate your issue as a test and open a PR with it to prove something isn't right.

[crodwell]

Hi @fenollp , thanks for the quick reply. Fair enough, turns out this issue is nothing to do with gin gonic and I can reproduce it in the test cases:

#357

[fenollp]

Thanks for the bug PR!

Ah it seems you're hitting #118
I'd love to review your PR on this :)

[crodwell]

I'm not sure it is the same as being unable to process localhost. I first came across the problem connecting to a development server that was defined as

servers:
  - url: 'http://192.168.0.30:3000'
    description: API

As I said on my second comment, I can work around it - but I'm not sure I should be submitting that as a PR as it's probably used for another scenario I'm unfamiliar with

[crodwell]

oh, or I can just remove the servers from the spec altogether and it works fine without changing code :)

[fenollp]

Isn't the whole of 192.168 submask LAN? In any case these hosts are probably handled similarly to localhost by Golang.
I still believe this is #118. See this comment on how/why local hosts don't match the legacy router: #118 (comment)

I can remove the servers altogether and it works

is discussed there as well :)