Panicking on unresolved ref

[Jleagle]

Hi, I am calling openapi3filter.ValidateRequest() (via https://github.com/deepmap/oapi-codegen/blob/master/pkg/chi-middleware/oapi_validate.go#L23) and I am getting

panic: Validating Swagger failed: invalid components: found unresolved ref: "#/components/schemas/product-price-schema"

If I remove the places that use product-price-schema, the same thing happens to stat-schema. As far as I can tell the JSON is according to spec.

The OpenAPI3 JSON is here (https://globalsteam.online/api/globalsteam.json), both the schemas exist inside #/components/schemas/

Any ideas? Thanks.

[fenollp]

So to recap https://globalsteam.online/api/globalsteam.json seems to be a valid OpenAPIv3 spec according to https://editor.swagger.io/

Your code uses kin-openapi v0.37.0 https://github.com/deepmap/oapi-codegen/blob/26bb06c00b13ddc6c26107402b8fa398be98ea29/go.mod#L5 try using the latest tag as it has changes related to refs v0.37.0...master

Your code calls https://github.com/deepmap/oapi-codegen/blob/3e0fd9593a08e23613736071c8938ed4cbdde704/pkg/codegen/templates/inline.tmpl#L24 which calls

kin-openapi/openapi3/swagger_loader.go

Line 151 in 0ef6b18

if err := swaggerLoader.ResolveRefsIn(doc, nil); err != nil {

Note: this code should also be calling

kin-openapi/openapi3/swagger.go

Line 49 in 0ef6b18

func (swagger *Swagger) Validate(c context.Context) error {

Please see about the two points in italics.

[Jleagle]

Thanks! I got kin-openapi updated in oapi-codegen. It still panicked inside WithSwagger().

Running my Swagger{} through openapi3.NewSwaggerLoader().ResolveRefsIn(swagger, nil) before parsing it into WithSwagger() fixed the panic. Just doesnt seem to work with refs.

My code is basically just:

swagger:= &openapi3.Swagger{}
router := openapi3filter.NewRouter().WithSwagger(swagger)
route, pathParams, err := router.FindRoute(r.Method, r.URL)

The reason it can't find the route is because r.URL.Scheme & r.URL.Host were empty so it couldnt compare to the server addresses inside my swagger to.

[Jleagle]

Ended up using this middleware:

func fixRequestURL(next http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

		if config.IsLocal() {
			r.URL.Scheme = "http"
			r.URL.Host = r.Host
		} else {
			r.URL.Scheme = "https"
			r.URL.Host = "api.xxx.com"
		}

		next.ServeHTTP(w, r)
	})
}

as the scheme/host are not always set but kin-openapi seems to require them to be.

[fenollp]

cc #118