Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme doesn't render properly with Galaxy Note #16

Closed
thierrymarianne opened this issue Aug 18, 2014 · 14 comments
Closed

Default theme doesn't render properly with Galaxy Note #16

thierrymarianne opened this issue Aug 18, 2014 · 14 comments
Labels

Comments

@thierrymarianne
Copy link

Hello,

I've noticed the default theme shipped with grav doesn't fit with the Galaxy Note (GT-N7000) native browser (embedded in Android 4.1.2)

Maybe you have some insights about how to fix the stylesheet for this particular version of the native Android browser?

P.S. : Rendering with Chrome is totally OK!

@rhukster
Copy link
Member

Well we're only using standard media queries. It seems there was some issues with this in your version of Android:

https://code.google.com/p/android/issues/detail?id=61929

I'm not aware of any way to fix this.

@mahagr
Copy link
Member

mahagr commented Aug 19, 2014

Confirmed the issue in Android 4.1.2 (by using Samsung S3 mini). Actually there are also other issues with it; might be similar to IE9 issues.

@mahagr mahagr added the bug label Aug 19, 2014
@thierrymarianne
Copy link
Author

@rhukster Well noted.

@mahagr Thank you for having confirmed this issue.

@rhukster
Copy link
Member

I'll close this for now because it looks like a browser bug that is out of our control. If someone finds a workaround, we'll open this back up and fix. Cheers.

@thierrymarianne
Copy link
Author

Quite efficient way of dealing with issues 👍 I'll let you know if I figure something about this otherwise I would have probably changed devices in between :P Thank you for your attention! Cheers!

@thierrymarianne
Copy link
Author

For the record, I figured the aforementioned layout break affecting the Galaxy Note and Samsung S3 mini devices, might be provoked by the use of rem in media queries (the use of em as measurement unit would help a bit but the menu would still be seen as broken).

Debugging with Edge Inspect was quite helpful.
Some people also recommended the use of weinre.

@rhukster
Copy link
Member

I did not know that! Thanks for tracking this down, we will investigate further and find a resolution.

cheers!

Andy

On Aug 21, 2014, at 3:58 PM, Thierry Marianne [email protected] wrote:

For the record, I figured the aforementioned layout break affecting the Galaxy Note and Samsung S3 mini devices, might be provoked by the use of rem in media queries (the use of em as measurement unit would help a bit but the menu would still be seen as broken).

Debugging with Edge Inspect was quite helpful.
Some people also recommended the use of weinre.


Reply to this email directly or view it on GitHub.

@rhukster rhukster reopened this Aug 21, 2014
@thierrymarianne
Copy link
Author

Thank you, @rhukster!

@rhukster
Copy link
Member

Can you please try getgrav.org again? we have changed from rem to em. If that works fine for you, we'll update all the other sites and themes. Cheers!

@thierrymarianne
Copy link
Author

Perfect! Thank you!

grav-default-theme_2014-08-22-08-25-30

@rhukster
Copy link
Member

Looking 'nearly' perfect. There does seem to be the mobile navigation button 'hamburger' missing from the top right corner. Just have to find out what's up with that and we should be good! Thanks for helping to sort this out with us!

@thierrymarianne
Copy link
Author

@rhukster I don't know why the menu doesn't appear on this screenshot (maybe I hit too fast the combination of buttons earlier in the morning), nonetheless I confirm it works (the 'hamburger' menu button is available and it can be clicked) as it should on Galaxy Note (GT-N7000) using the native Android browser. I guess this issue could be closed if @mahagr confirms the rendering is fixed for S4 mini as well.

Thanks!

screenshot_2014-08-22-22-35-30

@rhukster
Copy link
Member

Yah we have worked today on various fixes. The hamburger button missing is a widespread android button with that special entity character. We switched to a font-icon and it works again. Also we disabled animations for android and ios, that should make things run a bit smoother overall. I'm going to close this. Thanks for all your help!

@thierrymarianne
Copy link
Author

Great! Have a nice week end :) You people did an amazing job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants