Nicetime fix: 0 seconds from now -> just now #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if date matches, which means the post / comment was posted just now. Will return proper value to whatever function uses it. The file /system/languages/en.yaml and basically all language files need to include the JUST_NOW text value which should be "just now", of course correctly translated in each language. This fix has been created in order to fix the "0 seconds from now" message as it sounds weird.
Should be translated to other languages and included in all translation files.
Update TwigExtension.php - Fixing nicetime when post time equals current date
Update en.yaml - Add JUST_NOW variable
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the weird message that appears when the posting time equals the current date, for example if a user submits a comment and checks the time their comment was posted right away.
Will probably require the JUST_NOW variable to be added to all translations.