feat: Split cache name and label #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every cache is a file under the
cache_dir. Previously we're using the metrics labels as the cache file name. This works when there's a unique cache for each endpoint.However, as we're going to introduce blue green cache again, this naming convention can not be used anymore.
Here we add a
nameparameter toRwCacheManager::create_cache, to allow the user to use a different name from the labels. The labels only affects the metrics labels now. And we can open the same cache while attaching different labels.The plan is to use the labels as cache alias to enable switching between blue green cache.