-
Notifications
You must be signed in to change notification settings - Fork 208
[Clean Version] Extend PR #3089 – Complete Fiat Input Support in Dual Currency Field #3395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dunsin-cyber
wants to merge
21
commits into
getAlby:master
Choose a base branch
from
Dunsin-cyber:clean-refine-dual-currency
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Clean Version] Extend PR #3089 – Complete Fiat Input Support in Dual Currency Field #3395
Dunsin-cyber
wants to merge
21
commits into
getAlby:master
from
Dunsin-cyber:clean-refine-dual-currency
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecks and save flow
9 tasks
Contributor
Author
|
hi @pavanjoshi914 , this PR is now ready for review 🚀⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Summary
This pull request continues from where #3089 left off and cleans up the messy rebase/force-push in #3394. That initial PR laid the groundwork, and this one builds upon it to complete the implementation and resolve remaining issues.
✨ Changes Introduced
A breakdown of what this PR introduces:
ConfirmPaymentandSitePreferences.Added a default mock implementation for
getFormattedInCurrencyin theSettingsContext. This resolves the failing unit tests inConfirmPayment/index.test.tsxcaused by a missing mock.🔗 Related Issues or PRs
🧩 Type of Change
Select the appropriate type:
fix: Bug fix (non-breaking change which fixes an issue)feat!: Breaking change (may break existing functionality)📸 Screenshots (optional)
Add any relevant screenshots, screen recordings, or UI diffs to help reviewers.
🧪 How This Was Tested
✅ Checklist
For UI-related changes: