Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change iconset to Popicons #2920

Closed
stackingsaunter opened this issue Dec 11, 2023 · 7 comments · Fixed by #3072
Closed

Change iconset to Popicons #2920

stackingsaunter opened this issue Dec 11, 2023 · 7 comments · Fixed by #3072
Assignees
Labels
frontend All things frontend development related good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Dec 11, 2023

Swap all existing icons in the extension to ones from open source iconset Popicons.
There is possible a react import, see here:
https://github.com/uxthings/popicons

Current designs with new icons can be viewed here (currently file is a bit messy, but that shouldn't affect this issue)

Note: In the designs I use a default viewbox 24x24 for icons, and if they are rescaled, they are rescaled from that viewbox

There a few custom icons that are not in the set, and are included here:

  • puzzle
  • face-surprise
  • arrow-up-right

These are some icons currently implemented that can stay (because there's no popicons version):

  • chevrons
  • "Connnected Sites" (alby with checkmark)
@MayaSatishRao
Copy link

@stackingsaunter I want to contribute to this issue. Can I work on this?

@stackingsaunter
Copy link
Contributor Author

@MayaSatishRao go ahead

@MayaSatishRao
Copy link

@stackingsaunter i ran the project successfully. And I don't know how to proceed further?
Screenshot 2024-01-06 134429
Also, which package is currently used for icons?

@MayaSatishRao
Copy link

@stackingsaunter which wallet should I connect?

@stackingsaunter
Copy link
Contributor Author

@MayaSatishRao hey, I don't know what you mean exactly. You can connect any way you want. It shouldn't matter in relation to the issue.

Currently we're using https://bitcoinicons.com/

@amitamrutiya
Copy link
Contributor

Hey @MayaSatishRao , are you still working on this issue? If not, then @stackingsaunter, I would like to try tackling this good first issue.

@reneaaron
Copy link
Contributor

@amitamrutiya2210 Feel free to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend All things frontend development related good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants