-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change iconset to Popicons #2920
Comments
@stackingsaunter I want to contribute to this issue. Can I work on this? |
@MayaSatishRao go ahead |
@stackingsaunter i ran the project successfully. And I don't know how to proceed further? |
@stackingsaunter which wallet should I connect? |
@MayaSatishRao hey, I don't know what you mean exactly. You can connect any way you want. It shouldn't matter in relation to the issue. Currently we're using https://bitcoinicons.com/ |
Hey @MayaSatishRao , are you still working on this issue? If not, then @stackingsaunter, I would like to try tackling this good first issue. |
@amitamrutiya2210 Feel free to submit a PR! |
Swap all existing icons in the extension to ones from open source iconset Popicons.
There is possible a react import, see here:
https://github.com/uxthings/popicons
Current designs with new icons can be viewed here (currently file is a bit messy, but that shouldn't affect this issue)
Note: In the designs I use a default viewbox 24x24 for icons, and if they are rescaled, they are rescaled from that viewbox
There a few custom icons that are not in the set, and are included here:
These are some icons currently implemented that can stay (because there's no popicons version):
The text was updated successfully, but these errors were encountered: