New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch does not check if response is ok before trying to decode json #31

Open

rolznz opened this issue May 16, 2023 · 0 comments

Labels

good first issue

Contributor

rolznz commented May 16, 2023

async fetchWithProxy() {
    const result = await fetch(`${this.options.proxy}/lightning-address-details?${new URLSearchParams({ ln: this.address }).toString()}`);
    const json = await result.json(); // <---------------

    this.parseResponse(json.lnurlp, json.keysend, json.nostr);
  }

This causes an error like:

FetchError: invalid json response body at https://lnaddressproxy.getalby.com/lightning-address-details?ln=donate%40btcpay.bitcoinsmiles.org reason: Unexpected token < in JSON at position 0

rolznz added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment