Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Tie Interceptor to match X-Wing v2 database #68

Open
mludowise opened this issue Dec 9, 2018 · 1 comment
Open

Rename Tie Interceptor to match X-Wing v2 database #68

mludowise opened this issue Dec 9, 2018 · 1 comment

Comments

@mludowise
Copy link
Contributor

We should update the ID from tieinterceptor to tieininterceptor to match the v2 database.

There was some discussion in the xwing-data2 repo over whether the ID should be updated or not, but it looks like the conclusion is that the ID should match the new FFG name for the ship which is Tie/In Interceptor:
xwingtmg/xwing-data2#93 (comment)

@davidhorm
Copy link

Same story with tiesilencer should be renamed to tievnsilencer to match xws id...or maybe allow both IDs to work if you want to make it backwards compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants