Update code style in dynamic core plugin #6177
Merged
+259
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Dec 10, 2024
|
|
||
| /** | ||
| * Compute the core solidus at certain pressure | ||
| * Compute the core solidus at certain pressure @p pressure | ||
| * and light element concentration @p X (in wt.%). |
There was a problem hiding this comment.
swap the order of the parameters in the doc?
| for (unsigned i=1; i<=n; ++i) | ||
| S+=B/std::sqrt(M_PI)*std::exp(-std::pow(i,2)/4.)/i*std::sinh(i*R/B); | ||
| double S=R/(2.*std::sqrt(numbers::PI)); | ||
| for (unsigned int i=1; i<=n; ++i) |
There was a problem hiding this comment.
n is a double but compared to an int?
|
Thanks, I will open a new PR which addresses your comments and some more in a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #6168 I noticed that the dynamic core boundary temperature plugin could urgently use an update to our current coding style. This PR goes through the header and source file of dynamic_core and fixes a first batch of issues:
constqualifiers to variables and functionsM_PIwithnumbers::PIin a bunch of placesNo functionality was changed and I tried to avoid changes that could introduce subtle bugs.
There is still more that could be done in a follow-up PR, but I avoided that here on purpose, e.g.:
But I will leave that for a follow-up for later.