Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update continental extension cookbook #6117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naliboff
Copy link
Contributor

@naliboff naliboff commented Oct 31, 2024

This is a work in progress PR to update the continental extension cookbook.

The changes include:

  1. Multiple updates to the model design, include the use of active particles, improving the readability of the material model, and updated flow law parameters.
  2. Addition of a script to illustrate how the flow law prefactor scaling values are calculated

The above changes do affect the model dynamics, with an example image of the viscosity after 5 Myr included below.

@gassmoeller (and others) - I thought it would be easiest to discuss changes to the PRM file first before updating the documentation files.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.
    continental_extension_cookbook_5Ma

@naliboff naliboff requested a review from gassmoeller October 31, 2024 15:42
@gassmoeller
Copy link
Member

I think the changes make sense. Go ahead with the rest of the update.

@gassmoeller
Copy link
Member

@naliboff can you remind me if this rework is necessary for the release? I just reran the current continental extension cookbook and it at least converges pretty fine and looks pretty similar to what we have on the website:

My result (slightly different colorscale):
Screenshot from 2024-11-08 16-23-31

Fig. 105 in Documentation

The reason I am asking is that this is a pretty substantial rewrite of the cookbook, and I would like to create the release soon. Does it matter if this rewrite goes into the release or is merged afterwards?

@naliboff
Copy link
Contributor Author

@gassmoeller - Thanks for checking the model on your end. My motivation for including this PR in the release was to highlight the updated solver settings, use of particles, and formatting of the material model section. Incremental, but certainly very useful improvements. Absolutely ok if this is merged after the release, with the only caveat being that this is the version of the cookbook we will want to use in future tutorials (i.e., will it be a problem to use the main branch for the hubzero notebooks)?

@gassmoeller
Copy link
Member

I guess either way is fine with me, I would just like to get the release out in the next 1-2 weeks, and all other features we wanted are already merged so we can test them now. Changing something right before a release has the risk of requiring a point release to fix unrecognized bugs. I would suggest we just proceed with this PR and see when it is ready, if before the release I am ok including it, if afterwards I see no point in delaying the release further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants