Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite-Difference Notes #484

Open
feathern opened this issue Jun 29, 2023 · 0 comments
Open

Finite-Difference Notes #484

feathern opened this issue Jun 29, 2023 · 0 comments

Comments

@feathern
Copy link
Contributor

feathern commented Jun 29, 2023

These are some potential issues that I'm making note of while working on the initial finite-difference documentation.

  1. It looks as though when a nonuniform grid is specified through dr_input, there is no consistency check to ensure that radius(1) is equivalent to rmax. It's possible this could cause issues in other parts of the code where rmax is used explicitly.
  2. We should also set dr_input to -1 by default, rather than 0 so that we're not doing an exact comparison of two real numbers. I worry about the logical check of IF (dr_input(n_r) .eq. 0.0) possibly failing in some instances otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant