Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eqn_coeff_version (still = 1?) #425

Open
illorenzo7 opened this issue Dec 23, 2022 · 1 comment
Open

eqn_coeff_version (still = 1?) #425

illorenzo7 opened this issue Dec 23, 2022 · 1 comment

Comments

@illorenzo7
Copy link
Contributor

I'm doing some clean-up of the PDE_Coefficients file, and noticed that the eqn_coeff_version is still set to 1. Is this right? I feel like the version has changed, what with the addition of the scalar diffusions. Maybe I am missing something.

@illorenzo7 illorenzo7 changed the title eon_coeff_version (still = 1?) eqn_coeff_version (still = 1?) Dec 23, 2022
@feathern
Copy link
Contributor

feathern commented Jan 5, 2023

I'm not sure that the additional scalar fields are completely working with things like the custom reference state and maybe the equation coefficients file. My understanding was that they mainly work for Boussinesq mode at the moment. Though I would think they would be in the coeff file. Let's see what @cianwilson has to say -- either here or during the developer meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants