-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024リニューアル:ImageCDN-Bun #389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentksb
force-pushed
the
migration-to-ssr-cfimage-biome
branch
from
June 22, 2024 12:50
5ec09ed
to
ba553a6
Compare
gentksb
force-pushed
the
migration-to-ssr-cfimage-biome
branch
from
June 23, 2024 10:44
00ef665
to
a61631e
Compare
This was
linked to
issues
Jul 21, 2024
Closed
Closed
Closed
Closed
Open
各所にtext-wrapのCSS属性を追加していく |
Open
バリューコマースタグだけZarazで動作しない… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ねらい
ビルド時間の大半がレスポンシブ画像のレンダリングに費やされているため、SSR化してリクエスト時にCloudflare Image Resizingを使った画像変換に置き換えてアクセス時に画像を生成+キャッシュする方針に切り替えるSSR化はとりやめ、unpicによる画像CDNサービス利用のみを行う考慮事項
個別の記事ページのみ、SSRする。それ以外のページ(特に一覧系)はメモリに全記事を読み込むと表示遅延やWorkersのリソース制限に引っかかるなどのデメリットが大きいため、プリレンダリングしておく。この方針でもWorkerの無料プラン制限を超えるため、SSG前提にする
Cloudflareの機能を活用する。少なくともPartyRockをCloudflare Zaraz に置き換えることにチャレンジ。ロギングもbaselimeを利用する
テストに加えエラーログとSlack通知を実装する。
ToDo
LinkBox
コンポーネントの分割Twitter, instagramのリンクをZarazによる実装への置き換えを試す(SSGでも実行できるか未知数)使い物にならないので却下タグページの作成SSGだとタグを型で縛る必要があるので別途実装お掃除