Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve Collection::filter method to not retain indices. #13

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: Improve Collection::filter method to not retain indices. #13

merged 1 commit into from
Mar 29, 2023

Conversation

b00gizm
Copy link
Contributor

@b00gizm b00gizm commented Mar 28, 2023

Wrapping \array_filter with \array_values forces a reindex.

refs: #12

@b00gizm b00gizm linked an issue Mar 28, 2023 that may be closed by this pull request
Collection::filter() retains indices. #12
Closed
@b00gizm b00gizm requested a review from janvt March 28, 2023 15:55
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@b00gizm b00gizm merged commit 1848c02 into main Mar 29, 2023
@b00gizm b00gizm deleted the fix/12-collectionfilter-retains-indices branch March 29, 2023 11:35
@github-actions github-actions bot mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvt janvt janvt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection::filter() retains indices.
2 participants
@b00gizm @janvt