Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Length of the destination address is not checked on frontend #222

Closed
mertwole opened this issue Nov 29, 2024 · 3 comments · Fixed by #224
Closed

Length of the destination address is not checked on frontend #222

mertwole opened this issue Nov 29, 2024 · 3 comments · Fixed by #224
Assignees
@nikitayutanov
Labels
bug frontend

Comments

@mertwole
Copy link
Member

No description provided.

@nikitayutanov
Copy link
Member

For which network, Vara or Ethereum? There are validation checks for both of them.

On Vara we're trying to decode address via keyring, and if decoding is successful - provided address is valid.
Same thing happens for Ethereum, I guess, except there's a ready isAddress util.

@mertwole
Copy link
Member Author

image
image
But approve will be sent

@mertwole
Copy link
Member Author

It's validated correctly in the vara->eth transfer

This was referenced Nov 29, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitayutanov nikitayutanov

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend): validate ss58 address length gear-tech/gear-bridges
2 participants
@mertwole @nikitayutanov