Correct tick count in profiler output. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Genhis
force-pushed
the
issue_8
branch
2 times, most recently
from
6b74d4e
to
f9e86bd
Compare
gdborton
requested changes
Apr 27, 2017
screeps-profiler.js
Outdated
| @@ -147,7 +147,8 @@ const Profiler = { | |||
| return 'Profiler not active.'; | |||
| } | |||
|
|
|||
| const elapsedTicks = Game.time - Memory.profiler.enabledTick + 1; | |||
| const elapsedTicks = (Memory.profiler.type === 'background' ? Game.time : | |||
There was a problem hiding this comment.
Can you split this line up? Maybe a const endTick = ... the two line ternary isn't terribly easy to read.
Prevously calling `Game.profiler.output()` after a profile had finished running would generate a report with the wrong ending tick. This adds logic to make the disableTick the ending tick for the profiler report leading to accurate numbers.
gdborton
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8: Fixed a bug when Game.profiler.output() showed incorrect Avg and Ticks numbers.