Add profiling for getters and setters #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES6 getter-Functions are invoked, even when called from prototype. This fix uses Object.getOwnPropertyDescriptor and checks if the get or set property is present.
|
Seems legit to me, my subscription has lapsed, but I want to check this out before pulling it in. Should I close the other pr in favor of this one? |
|
I've taken care of the other PR, thank you for having a look at it. |
|
@gdborton any progress on this pull request? |
|
Seems legit. I know this has been pending for a long time, and that you've got a fork running. Is there anything that you need to update before merging? |
|
I think this is in a fine state right now and ready to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #10 as that PR kind of breaks profiling of getters.
This will only add profiling to configurable getters and setters, this has to be set
trueexplicitly.See more at Object.defineProperty.