Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for strikethrough desired #256

Closed
Bios-Marcel opened this issue Feb 10, 2019 · 3 comments
Closed

Support for strikethrough desired #256

Bios-Marcel opened this issue Feb 10, 2019 · 3 comments
Labels
enhancement
Milestone
v2

Comments

@Bios-Marcel
Copy link
Contributor

Hey,

I was wondering if it would technically be possible to support italic and strikethrough?
@gdamore
Copy link
Owner

gdamore commented Feb 18, 2019

There is a PR for italic support already. I need to follow up on this. Strikethrough might be similar or harder, depending on what the terminal escape sequences support.

@diamondburned
Copy link

diamondburned commented Mar 10, 2019 •
edited
Loading

There is already a fork with italics and strikethrough. Cherry-picking this shouldn't be hard. Here's a preview that I implemeted with a forked tview.

@mjarkk mjarkk mentioned this issue Oct 21, 2019
Open
@Bios-Marcel Bios-Marcel mentioned this issue Feb 23, 2020
Open
@gnojus gnojus mentioned this issue Mar 26, 2020
Merged
@tculp tculp mentioned this issue Aug 26, 2020
Closed
@gdamore gdamore changed the title Supporting the text attributes strikethrough and italic Supporting the text attributes strikethrough Aug 30, 2020
@gdamore gdamore added this to the v2 milestone Aug 30, 2020
@gdamore gdamore changed the title Supporting the text attributes strikethrough Support for strikethrough desired Aug 30, 2020
@gdamore
Copy link
Owner

gdamore commented Aug 31, 2020

This is a duplicate of #350

@gdamore gdamore closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2
Development

No branches or pull requests
3 participants
@gdamore @diamondburned @Bios-Marcel