Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only mode CM #2710

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Read only mode CM #2710

wants to merge 4 commits into from

Conversation

AdiMakkar
Copy link
Contributor

closes #2682

@AdiMakkar AdiMakkar self-assigned this Feb 6, 2025
Copy link

GCcollab test instance up at: https://gccollab-dev-pr-2710.azurewebsites.net/
GCconnex test instance up at: https://gcconnex-dev-pr-2710.azurewebsites.net/

@Phanoix
Copy link
Contributor

Phanoix commented Feb 10, 2025

Not sure if we want to also get rid of the "offer" and "remove" buttons for when there are people who applied, those buttons are added in https://github.com/gctools-outilsgc/gcconnex/blob/master/mod/missions/views/default/page/elements/related-candidates.php
They won't work in the full read only mode, but only the one who created the opportunity will see them if there are applicants and I'm not sure how often people use the apply option on the site VS. just emailing the person who posted it.

Copy link
Contributor

@Phanoix Phanoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well from what I can tell, see my other comment for something that we may or may not want to add since it might only be visible in a small minority of cases and those buttons won't work anyways in full read only mode.

@AdiMakkar
Copy link
Contributor Author

AdiMakkar commented Feb 13, 2025

@Phanoix will wait for your thumbs up on this comment and merge the decommission of 'offer' and 'removal' with other components of CM being decommissioned. Test instance screenshots just for reference on my local side for CM in NOT in read-only mode vs CM in read-only mode:
Screenshot 2025-02-13 at 1 59 04 PM
Screenshot 2025-02-13 at 1 59 36 PM

@Phanoix
Copy link
Contributor

Phanoix commented Feb 13, 2025

Is completely removing the list of applicants how we want to go about it instead of just removing the buttons? Seems to me like it's removing information that some people might look for but if this is what we're going with then this does do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCconnex Decom - Read Only Mode Mod for the Career Marketplace Types
2 participants