-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read only mode CM #2710
base: master
Are you sure you want to change the base?
Read only mode CM #2710
Conversation
GCcollab test instance up at: https://gccollab-dev-pr-2710.azurewebsites.net/ |
Not sure if we want to also get rid of the "offer" and "remove" buttons for when there are people who applied, those buttons are added in https://github.com/gctools-outilsgc/gcconnex/blob/master/mod/missions/views/default/page/elements/related-candidates.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well from what I can tell, see my other comment for something that we may or may not want to add since it might only be visible in a small minority of cases and those buttons won't work anyways in full read only mode.
@Phanoix will wait for your thumbs up on this comment and merge the decommission of 'offer' and 'removal' with other components of CM being decommissioned. Test instance screenshots just for reference on my local side for CM in NOT in read-only mode vs CM in read-only mode: |
Is completely removing the list of applicants how we want to go about it instead of just removing the buttons? Seems to me like it's removing information that some people might look for but if this is what we're going with then this does do it. |
closes #2682