Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test issue for non-Intel architectures #78

Open
tillea opened this issue Mar 11, 2024 · 4 comments
Open

Test issue for non-Intel architectures #78

tillea opened this issue Mar 11, 2024 · 4 comments

Comments

@tillea
Copy link

tillea commented Mar 11, 2024

Hi,
after upgrading the Debian package from version 2.1.8.1 to 2.1.9 the CI test we are running on different architectures failed for all non-Intel architectures which you can see in the debci check matrix. When you have a look into one of the test logs - for instance for arm64 you can find the problem is here:

 ----- FAILED[data]: test_least_squares.R<68--69>
  call| expect_true(abs(mean(data2$Y - f.predict)) < 0.01, info = "LS: checking if Gaussian absolute error within tolerance.")
  diff| Expected TRUE, got FALSE
  info| LS: checking if Gaussian absolute error within tolerance.
 ----- FAILED[data]: test_least_squares.R<70--71>
  call| expect_true(sd(data2$Y - f.predict) < sigma, info = "LS: checking if Gaussian squared error within tolerance.")
  diff| Expected TRUE, got FALSE
  info| LS: checking if Gaussian squared error within tolerance.
 Error: 2 out of 5 tests failed
 Execution halted

It might be that relaxing the test condition could help passing this test again but I have to less knowledge about the internals of this package.

Kind regards, Andreas.

@tillea
Copy link
Author

tillea commented Apr 16, 2024

Ping?

@tillea
Copy link
Author

tillea commented Apr 25, 2024

I wonder if the silence about this bug is connected to the advise to switch to gbm3. Unfortunately there are several packages in Debian (and thus CRAN) that depend on this version of gbm. I wonder whether the issue is visible also on CRAN test builds on non-Intel architectures.

@gregridgeway
Copy link
Contributor

Silence mostly due to day jobs.

Can you try the following:

  1. Install from github if you can't from CRAN, remotes::install_github("gbm-developers/gbm")
  2. Run the test script inst/tinytest/test_least_squares.R
  3. Let us know what the value of
    best.iter
    mean(data2$Y - f.predict)
    sd(data2$Y - f.predict)

@tillea
Copy link
Author

tillea commented Apr 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants