Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Rewrite using askama and htmx #179

Merged
merged 39 commits into from
Jun 4, 2024
Merged

feat!: Rewrite using askama and htmx #179

merged 39 commits into from
Jun 4, 2024

Conversation

gbbirkisson
Copy link
Owner

@gbbirkisson gbbirkisson commented Feb 9, 2024

Combine workspace into a single project and use a combination of askama, htmx and hyperfine to render the webpage. Drop sycamore and the whole web assembly bit. I believe this will simplify the project and make it easier to maintain and add features.

@gbbirkisson gbbirkisson self-assigned this Feb 9, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 5.24590% with 289 lines in your changes missing coverage. Please review.

Project coverage is 6.89%. Comparing base (f649d25) to head (15b1958).

Files Patch % Lines
src/server/hx/gallery.rs 0.00% 64 Missing ⚠️
src/db.rs 0.00% 51 Missing ⚠️
src/server/hx/mod.rs 0.00% 43 Missing ⚠️
src/server/hx/preview.rs 0.00% 33 Missing ⚠️
src/server/hx/bar.rs 0.00% 26 Missing ⚠️
src/server/assets.rs 0.00% 25 Missing ⚠️
src/pipeline.rs 0.00% 14 Missing ⚠️
src/main.rs 0.00% 9 Missing ⚠️
src/server/mod.rs 50.00% 7 Missing ⚠️
src/lib.rs 60.00% 6 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #179      +/-   ##
=========================================
- Coverage   11.66%   6.89%   -4.78%     
=========================================
  Files          23      16       -7     
  Lines        1037     725     -312     
=========================================
- Hits          121      50      -71     
+ Misses        916     675     -241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbirkisson gbbirkisson changed the title feat!: Major refactor feat!: Rewrite using askama and htmx Jun 4, 2024
@gbbirkisson gbbirkisson marked this pull request as ready for review June 4, 2024 15:05
@gbbirkisson gbbirkisson merged commit 8044ac1 into main Jun 4, 2024
7 of 9 checks passed
@gbbirkisson gbbirkisson deleted the refactor branch June 4, 2024 15:05
gbbirkisson added a commit that referenced this pull request Jun 4, 2024
Combine workspace into a single project and use a combination of askama,
htmx and hyperfine to render the webpage. Drop sycamore and the whole
web assembly bit. I believe this will simplify the project and make it
easier to maintain and add features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant