Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

Follow install node instructions but - Cannot find module 'web-push' #113

Open
JessePerry opened this issue Sep 3, 2018 · 0 comments
Open

Comments

@JessePerry
Copy link

Various issues encountered following install instructions in readme.md

Type of Issue

Install / documentation for install

Details

Not related to browser version because I didn't get that far, but I tried the install on both OSX (using terminal) and Windows (using bash). I'm fairly new to node and very new to ruby so I wasn't able to debug and continue with the install. Could you please update the install steps to be clearer?

Details about node install

To reproduce:

  • Follow the install instructions npm install, works.
  • Then Run node src/demos/node-server/index.js
    Expected: Node runs the web server fine.
    Actual: Get the error Cannot find module 'web-push'

Details about ruby and running the frontend.

  • Install Ruby 2.2.0 as per instructions
  • Run rvm . do bundle install
    Expected: bundle install works
    Actual: Get the error : rvm do bundle install was removed, use rvm 1.9.2,1.9.3 do bundle install or rvm all do bundle install instead.`

Moving on, and trying rvm all do bundle install
Expected: All required ruby bundles are installed
Actual: Error encountered ruby-dep requires Ruby 2.2.5
Full log:

.. successful install messages before this
Installing ruby_dep 1.5.0
Gem::RuntimeRequirementNotMetError: ruby_dep requires Ruby version >= 2.2.5, ~> 2.2. The current ruby version is 2.2.0.
An error occurred while installing ruby_dep (1.5.0), and Bundler cannot continue.
Make sure that `gem install ruby_dep -v '1.5.0' --source 'http://rubygems.org/'` succeeds before bundling.

In Gemfile:
  jekyll-github-metadata was resolved to 2.9.4, which depends on
    jekyll was resolved to 3.8.3, which depends on
      jekyll-watch was resolved to 2.0.0, which depends on
        listen was resolved to 3.1.5, which depends on
          ruby_dep

Note:
You may be interested in this bug raised with notifications in Chrome for Windows 10.
notificationclick does not fire for service worker for any notifications other than the most recent
https://bugs.chromium.org/p/chromium/issues/detail?id=872336
I was trying to adapt your sample to provide a minimum reproducible solution when I ran into the install issues. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant