fix(gatsby-source-graphql): add dataLoaderOptions validation to gatsby-source-graphql #36112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
that1matt
changed the title
imjoshin
added
topic: source-plugins
that1matt
force-pushed
the
gatsby-source-grapqhl-dataloader-options
branch
from
ad6e924
to
e8946bd
Compare
that1matt
force-pushed
the
gatsby-source-grapqhl-dataloader-options
branch
from
e8946bd
to
7d99cc6
Compare
|
@j0sh77 is there anything I need to do to help get this merged in? |
Sorry, this slipped through the cracks. Based off of https://github.com/graphql/dataloader#new-dataloaderbatchloadfn--options, this looks good to me. Thank you! 💜 Just gonna wait for the tests and I'll merge once those look good. |
imjoshin
approved these changes
Aug 24, 2022
imjoshin
changed the title
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced May 15, 2024
This was referenced May 15, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby-source-graphql throws warning when passing in
dataLoaderOptionsingatsby-config.js.Documentation
Grabbed initial types from dataLoaderOptions