fix(gatsby): fix eperm when cache getting cleared #35154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
type: bug
LekoArts
suggested changes
Mar 17, 2022
tyhopp
reviewed
Mar 18, 2022
| @@ -270,6 +269,7 @@ export async function initialize({ | |||
| ? lmdbCacheDirExists | |||
| : cacheJsonDirExists | |||
|
|
|||
| const { globby: glob } = await import(`globby`) | |||
There was a problem hiding this comment.
What's the reason for this not to be a static import?
There was a problem hiding this comment.
It's ESM only, i'll add a comment
https://unpkg.com/[email protected]/package.json
wardpeet
commented
Mar 18, 2022
LekoArts
approved these changes
Mar 18, 2022
marvinjude
previously approved these changes
Mar 18, 2022
|
I guess it's yarnl lock updates. I'll update it in different PR to figure it out |
wardpeet
force-pushed
the
fix/eperm-cache
branch
from
ecbe007
to
2d42a8e
Compare
LekoArts
approved these changes
Mar 22, 2022
pieh
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 6684c60)
pieh
pushed a commit
that referenced
this pull request
Mar 22, 2022
Co-authored-by: Ward Peeters <[email protected]>
|
Published in |
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced May 13, 2024
This was referenced May 14, 2024
This was referenced May 14, 2024
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes EPERM when cache needs to be cleared. We used
delanddeluses gracefulFs but it's not good enough on windows as it doens't retry enough.fs-extradoes a better job.Related Issues
Fixes #35086