Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): Pass format-specific options in image data resolver #28826

Merged
merged 1 commit into from
Jan 4, 2021
Merged

fix(gatsby-plugin-sharp): Pass format-specific options in image data resolver #28826

merged 1 commit into from
Jan 4, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jan 3, 2021

Fix a bug where auto-format images didn't pass-through the format-specific options

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 3, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 3, 2021
sidharthachatterjee
sidharthachatterjee approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@sidharthachatterjee sidharthachatterjee merged commit 7378fcf into master Jan 4, 2021
@sidharthachatterjee sidharthachatterjee deleted the fix/image-format-options branch January 4, 2021 09:17
@gatsbybot gatsbybot mentioned this pull request Jan 5, 2021
Merged
vladar pushed a commit that referenced this pull request Jan 5, 2021
@ascorbic @vladar
fix(gatsby-plugin-sharp): Pass format-specific options in image-data (#…
e5d0579 
…28826)

(cherry picked from commit 7378fcf)
gatsbybot pushed a commit that referenced this pull request Jan 5, 2021
@ascorbic
fix(gatsby-plugin-sharp): Pass format-specific options in image-data (#…
ceeb7d4 
…28826) (#28853)

(cherry picked from commit 7378fcf)

Co-authored-by: Matt Kane <[email protected]>
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(gatsby-plugin-sharp): Pass format-specific options in image-data (g…
19b9845 
…atsbyjs#28826)
@saurabharch saurabharch mentioned this pull request Nov 4, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Nov 4, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Nov 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Nov 5, 2022
Open
@0xSebin 0xSebin mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 6, 2022
Open
@saurabharch saurabharch mentioned this pull request Dec 25, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 25, 2022
Open
@0xSebin 0xSebin mentioned this pull request Dec 25, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
This was referenced Dec 25, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@0xSebin 0xSebin mentioned this pull request Dec 26, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 27, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 21, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Jun 21, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @sidharthachatterjee