feat(gatsby-source-graphql): Default Apollo Link fetch wrapper to show better API errors #28786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
antoinerousseau
changed the title
|
Thanks for the PR! Looks like a test needs updated https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/55837/workflows/c9813a24-52f9-4308-b7c2-1779939215dc/jobs/589688 |
vladar
added
topic: GraphQL
|
I've updated those failing tests |
vladar
approved these changes
Dec 29, 2020
vladar
added
the
bot: merge on green
|
Wow great, that was fast, thanks! |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…w better API errors (gatsbyjs#28786) * apollo fetch http error status * update tests Co-authored-by: Vladimir Razuvaev <[email protected]> Co-authored-by: gatsbybot <[email protected]>
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the source GraphQL API responds with an error (4xx/5xx), the default behavior is to try to read the response body anyway, which is, in case of errors, often unrelated JSON, or HTML, or empty.
In these cases, we throw an error showing the HTTP response code and status text, which is much more relevant.
The user is still free to override the default
fetchwrapper anyway.Documentation
https://www.gatsbyjs.com/plugins/gatsby-source-graphql/#how-to-use
https://www.apollographql.com/docs/link/links/http/#fetch-polyfill
Related Issues
#10487
#20892
#28766
Notes
We could add more logging by passing the
reporterto the wrapper and add somereporter.verbose(...)for stuff like the response body or the request body, but it might be better to leave that to the user since they can write their own fetch wrapper anyway.