Update showcase info for miyamadojinja.com #22620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnishiguchi
force-pushed
the
mnishiguchi/update-miyamadojinja-showcase
branch
from
08ccae2 to
4dfd4a2
Compare
mnishiguchi
force-pushed
the
mnishiguchi/update-miyamadojinja-showcase
branch
from
4dfd4a2 to
07f5e29
Compare
|
There are four typo warnings but they are correct Japanese words. |
|
Thanks for the PR! Since you're including a github link it'd be great if that README file including full instructions for running the site. For example: git clone, cd , npm install. |
|
@laurieontech You are absolutely right. I updated the site repo's README with instructions for installation. https://github.com/mnishiguchi/miyamadojinja/blob/master/README.md |
…e-miyamadojinja-showcase
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor improvement for Miyamadojinja's showcase info, including a typo.
TL;DR:
Japanses(wrong) ->Japanese(correct)Related PR: #20856