Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-remark-images-contentful): make clear error when loading non-existent image #21756

Merged
merged 3 commits into from
Feb 29, 2020

Conversation

hoangvvo
Copy link
Contributor

Description

The gives clear error if the plugin fails to load an image instead of an unambiguous axios error

Documentation

n/a

Related Issues

Close #21487

@hoangvvo hoangvvo requested a review from a team as a code owner February 26, 2020 07:06
wardpeet
wardpeet previously approved these changes Feb 29, 2020
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks great, thanks for putting in the work 💪. I'll publish on Monday

@wardpeet wardpeet merged commit 99e39a0 into gatsbyjs:master Feb 29, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 29, 2020

Holy buckets, @hoangvvo — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@hoangvvo
Copy link
Contributor Author

Awesome! This looks great, thanks for putting in the work . I'll publish on Monday

Thanks for fixing the test! So sorry I did not get a chance to look at it.

@wardpeet
Copy link
Contributor

wardpeet commented Mar 2, 2020

Published in [email protected]

No worries, thanks for doing the work!

@hoangvvo hoangvvo deleted the remark-image-contentful-404-error branch March 4, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-remark-images-contentful] Improve error visibility when trying to load non-existent image
2 participants