Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a blog post on why TypeScript is using Gatsby #20814

Merged
merged 6 commits into from
Jan 24, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Jan 23, 2020

Description

Adds a blog post after a recommendation by Dustin, which takes my more informal TS infra update and makes it a bit more cohesive and useful globally.

I'm open to feedback on content of the post, I think I found a nice way to end it

I'm currently about 20m into loading yarn start on the website to verify it works, if you do PR deploys then maybe that might happen sooner, so I figured I'd just make the PR

@orta orta requested a review from a team as a code owner January 23, 2020 13:12

### TypeScript Support

While not "out-of-the-box", with a little elbow grease (as of early 2020) to get comprehensive TypeScript support:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ensure that this matches our current docs for adding TS support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you have any official docs for it, might be a good thing to work a new page from?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascorbic - he's right. We don't have official docs for adding typescript support yet. Let's run this as-is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hashimwarren Let's fix that by making TypeScript work out of the box

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yes, not today!

hashimwarren
hashimwarren previously approved these changes Jan 23, 2020
Copy link
Contributor

@hashimwarren hashimwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks for this contribution. I fixed a few typos. This should be ready to publish

@hashimwarren hashimwarren requested a review from ascorbic January 23, 2020 21:09
hashimwarren
hashimwarren previously approved these changes Jan 24, 2020
@hashimwarren hashimwarren added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 24, 2020
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orta 🙌

@gatsbybot gatsbybot merged commit 672e059 into gatsbyjs:master Jan 24, 2020
@orta
Copy link
Contributor Author

orta commented Jan 25, 2020

work, thanks folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants