fix(www): fix background on gatsby version indicator in showcase #20689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves gatsbyjs#20686 Also ensures the version and stars are always pinned to the top most corner instead of sometimes floating based on the length of the author's name
wardpeet
suggested changes
Jan 20, 2020
There was a problem hiding this comment.
Hey,
Thanks for creating this fix and finding this one. It hasn't crossed my mind yet so 👍. The fix your created works but is in my opinion on the right one.
Can you remove your change and edit
https://github.com/gatsbyjs/gatsby/pull/20689/files#diff-00f21c292fd295cc7e493fd0630f3c07R92
and add the following to the css here
-css={{ display: `flex`, justifyContent: `space-between` }}
+css={{ display: `flex`, justifyContent: `space-between`, align-items: `start` }}| @@ -102,7 +102,7 @@ const StartersList = ({ urlState, starters, count, sortRecent }) => { | |||
| > | |||
| {owner} / | |||
| </span> | |||
| <span css={{ display: `flex` }}> | |||
| <span css={{ display: `flex`, maxHeight: '1rem' }}> | |||
There was a problem hiding this comment.
We should remove this one as it's more a hack than a fix.
Suggested change
| <span css={{ display: `flex`, maxHeight: '1rem' }}> | |
| <span css={{ display: `flex` }}> |
There was a problem hiding this comment.
Thank you for taking the time to review and suggest edits for my commit. Yes your proposed changes is definitely less hacky.
Using flex rules instead of maxHeight. Also updated to use backticks which I hadn't realised to maintain consistency.
wardpeet
approved these changes
Jan 20, 2020
wardpeet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20686
Also ensures the version and stars are always pinned to the top most
corner instead of sometimes floating based on the length of the author's
name
Description
Documentation
Related Issues