Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataLayerName check before push in event. #20551

Merged
merged 2 commits into from
Jan 14, 2020
+24 −1
Merged

Add dataLayerName check before push in event. #20551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0173b7
Add dataLayerName check before push in event.
Jan 12, 2020
438b220
Update browser test after data layer name check change.
Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/gatsby-plugin-google-tagmanager/src/__tests__/gatsby-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,23 @@ describe(`onRouteUpdate`, () => {

expect(window.dataLayer).toHaveLength(1)
})

it(`registers new data layer variable if dataLayerName is specified`, () => {
const { onRouteUpdate } = getAPI(() => {
process.env.NODE_ENV = `production`
})
const dataLayerName = `fooBarDataLater`
window[dataLayerName] = []

onRouteUpdate(
{},
{
dataLayerName,
}
)

jest.runAllTimers()

expect(window[dataLayerName]).toHaveLength(1)
})
})
6 changes: 5 additions & 1 deletion packages/gatsby-plugin-google-tagmanager/src/gatsby-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ exports.onRouteUpdate = (_, pluginOptions) => {
) {
// wrap inside a timeout to ensure the title has properly been changed
setTimeout(() => {
window.dataLayer.push({ event: `gatsby-route-change` })
let data = pluginOptions.dataLayerName
? window[pluginOptions.dataLayerName]
: window.dataLayer

data.push({ event: `gatsby-route-change` })
}, 50)
}
}