Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): fix broken snapshots #20434

Merged
merged 1 commit into from
Jan 6, 2020
Merged

chore(gatsby): fix broken snapshots #20434

merged 1 commit into from
Jan 6, 2020

Conversation

blainekasten
Copy link
Contributor

@blainekasten blainekasten commented Jan 6, 2020 •
edited
Loading

Thanks to @wardpeet this fixes broken tests in master

@blainekasten blainekasten requested a review from a team as a code owner January 6, 2020 15:28
@blainekasten blainekasten changed the title fix snapshots chore(gatsby): fix broken snapshots Jan 6, 2020
wardpeet
wardpeet approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 it!

@blainekasten blainekasten merged commit 08db7a4 into master Jan 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/snapshots branch January 6, 2020 16:11
@peabnuts123
Copy link
Contributor

It looks like the by-id and by-name snapshots got swapped and then overwritten - I faced this while making #20265. Are we sure this change was correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blainekasten @peabnuts123 @wardpeet